Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customize webpack plugins #549

Closed
vitramir opened this issue Jun 2, 2020 · 4 comments
Closed

Allow to customize webpack plugins #549

vitramir opened this issue Jun 2, 2020 · 4 comments

Comments

@vitramir
Copy link

vitramir commented Jun 2, 2020

I am trying to get Elastic APM (elastic/apm-agent-nodejs) to work with ncc.

At this point the only solution I have found is the webpack plugin. Here is the thread regarding this issue.

Is it acceptable to add the ability to add custom webpack plugins? It violates the Zero configuration principe, but it may be acceptable to configure it when using a module, not CLI.

I can make PR for this feature

@lionelB
Copy link

lionelB commented Sep 7, 2020

@vitramir we use elastic apm with out bundle using this command

NODE_ENV=production node -r elastic-apm-node/start ./dist/index.js",

also, you will probably need to add other env variables to configure the apm client

@Zn4rK
Copy link

Zn4rK commented Feb 20, 2021

This would be a great feature! I'm happy to submit a PR for this!

@JustinFeng
Copy link

Any update on this? agreed, this will be a great feature if it can make require-in-the-middle work with vercel/ncc bundled js.

In our case, we are using Datadog(which under the hood use require-in-the-middle to auto-instrument varies packages), as of now, we have to give up on ncc bundling to benefit from the auto instrumentation, which is sadly a tradeoff

@styfle
Copy link
Member

styfle commented Jan 2, 2023

There is no plan to expose webpack internals/plugins because that would make it near impossible to migrate from webpack to the successor, turbopack. See https://turbo.build/pack

It violates the Zero configuration principle

Correct. I suggest forking this repo if you want to configure webpack.

@styfle styfle closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants