Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom css properties on terminal font render ( webkit-font-smoothing ) #2864

Closed
2 tasks done
alxtz opened this issue Apr 18, 2018 · 7 comments
Closed
2 tasks done
Labels
👀 Awaiting Response Issue or PR is awaiting a response from the author

Comments

@alxtz
Copy link

alxtz commented Apr 18, 2018

Issue

In pre 2.0.0 of hyper.js, I'm able to customize the css props of the fonts in hyper.
One of my favorite, is to use -webkit-font-smoothing to make the font display more smooth.

Before

image

After

image

In 2.0.0

image

In 2.0.0, I believe all the x-row based css is deprecated, since the term windows is all rendering using canvas.

Is it still possible to do those customization in 2.0.0? The doc only revealed some very basic setup for it. https://hyper.is/

@alxtz
Copy link
Author

alxtz commented Apr 18, 2018

Maybe related to #2601 , is there no official way to change/hook in to the rendering?

@Tam
Copy link

Tam commented Apr 18, 2018

+1, would really like to get my fancy ligatures back!
x-screen x-row { font-variant-ligatures: initial; }

@albinekb
Copy link
Contributor

@Tam support for ligatures is up to xterm sadly. Since switching to canvas rendering ligatures is hard to support. see xtermjs/xterm.js#958

@alxtz
Copy link
Author

alxtz commented Apr 19, 2018

That is so sad..., the only reason I use hyper.js is only for the ability to use css props 🙁

@Stanzilla Stanzilla added the 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself label Apr 23, 2018
@Stanzilla
Copy link
Collaborator

So there are actually two problems here,

@alxtz The termCSS setting is now called just css so try with that.
@Tam sadly you will have to wait for the xtermjs team to implement that.

@Stanzilla Stanzilla added 👀 Awaiting Response Issue or PR is awaiting a response from the author and removed 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself labels Apr 23, 2018
@alxtz
Copy link
Author

alxtz commented Apr 24, 2018

@Stanzilla The issue is that neither termCSS nor css would allow the access the change the actual render of shell text.
That's the same problem with @Tam
image
Note: those css props are set by using css, as you mentioned.

@albinekb
Copy link
Contributor

Since hyper now renders with canvas, you are correct in that it doesn't change how fonts are rendered, some things can be changed via xterm API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Awaiting Response Issue or PR is awaiting a response from the author
Projects
None yet
Development

No branches or pull requests

4 participants