Coverage Service for Cobertura XML #30

jkrumow · 2014-10-12T19:04:21Z

Hi marklarr,
as promised here is the pull request for the Cobertura XML coverage service.

It generates a nice xml report conforming to the dtd (see here) including line and branch coverage.

Have a look at it and tell me what you think.

Cheers
tarbrain

Contains simple parser to bundle the file's lines of code by methods. TODOs: - ignore comments inside methods - skip lines between '/*' and '*/'

…her into feature/cobertura_reporter

…reporter

Needs refactoring.

…ss/> node.

…tection algoritm. Refactored rate calculation.

This reverts commit 1d87e2b.

Update spec and fixture.

jkrumow · 2014-10-16T17:05:53Z

Ok. I have made the changes - and added some fixes too.

ayanonagon · 2014-10-16T18:32:15Z

lib/slather/cobertura_coverage_file.rb

+      data.gsub(/^function(.*) called [0-9]+ returned [0-9]+% blocks executed(.*)$/, '')
+    end
+
+    def coverage_for_line(line)


Is overriding the super class' implementation necessary here?

Move code from for cobertura_coverage_file_spec into coverage_file_spec.

jkrumow · 2014-10-16T20:43:11Z

Ok. Merged CoberturaCoverageFile into CoverageFile.
Now there are three ways to get coverage data:

gcov_data with the raw line information including branch coverage information (lines which are no valid lines of code)
line_coverage_data formerly known as coverage_data where all branch coverage information is stripped out
branch_coverage_data which is a hash that groups the hit counts of the branches by the line number of the branch statement:

branch_coverage_data = {
    "15" : [ 0, 5, 2, 0] ,
    "32" : [ ..... ]
}

marklarr · 2014-10-17T08:28:20Z

lib/slather/coverage_file.rb

        gcov_data
      end
    end

-    def coverage_data
+    def line_coverage_data
      if gcov_data


if cleaned_gcov_data might be better now that we're using that below :)

Use integer for line_number in branch_coverage_data. Use cleaned_gcov_data. Simplified collection operations. Ruby-ficated implementation of num_branches_testable and num_branches_tested. Add devision by zero checks.

Extracts line of code with branch statement and all following "branch X taken / never excuted" annotations.

marklarr · 2014-10-21T08:24:05Z

tarbrain, thanks so much! This is a really good addition and you even learned some Ruby along the way!

Coverage Service for Cobertura XML

Julian Krumow added 30 commits October 5, 2014 16:40

Add spec for cobertura xml coverage service.

2d2316c

Add cobertura xml coverage service.

2648eb3

Add nokogiri to Gemfile.

e0c1f93

Add basic setup of cobertura report file.

6e1ab76

Add subtype of CoverageFile named CoberturaCoverageFile.

d886a04

Contains simple parser to bundle the file's lines of code by methods. TODOs: - ignore comments inside methods - skip lines between '/*' and '*/'

Add simple implementation of cobertura xml generator.

0248067

Use Nokogiri::XML::Builder to create xml document.

e50c9d2

Refactor and fix parser bugs.

33a8166

Improve pattern matching.

c12f225

Add TODOs.

e2db146

Set correct filename and class name in xml class node.

51a12b3

Set correct filename and class name in xml class node.

9a18b4d

Merge branch 'feature/cobertura_reporter' of github.com:tarbrain/slat…

5406e8e

…her into feature/cobertura_reporter

Cleanup code.

b602bd1

Refactor method parser.

77d2af2

Improve parser for methods.

527670a

Cleanup code.

26cc145

Updated error message.

b1c82ed

Cleanup code.

fa29224

Enhance cobertura_xml_spec.

8c7c2be

Set source directory and package name.

1c17cf4

Add regex to remove comments.

2b431cd

Extract comment filter regex into separate method.

061cad5

Merge remote-tracking branch 'origin/develop' into feature/cobertura_…

cca494e

…reporter

Add branch coverage.

b9fd7d4

Needs refactoring.

Duplicate all lines from methods below a node <lines/> below the <cla…

a81af84

…ss/> node.

Add branch rate for class, package and coverage nodes.

5a0adb7

Add level detection for opening and closing curly braces in method de…

3a1794f

…tection algoritm. Refactored rate calculation.

Simplified regex.

20d8d3f

Add mini version without <method> nodes.

f029271

Julian Krumow added 4 commits October 16, 2014 18:27

Revert "Corrected source dorectory handling."

52bd610

This reverts commit 1d87e2b.

Update README.md

6feb581

Using roote directory for entry in sources node.

dd30230

Update spec and fixture.

Merge branch 'master' of github.com:tarbrain/slather

117ada9

ayanonagon reviewed Oct 16, 2014
View reviewed changes

Julian Krumow added 3 commits October 16, 2014 22:19

Moved code from CoberturaCoverageFile to CoverageFile.

bab809d

Remove CoberturaCoverageFile.

bb8bd61

Move code from for cobertura_coverage_file_spec into coverage_file_spec.

Remove unnecessary setting of coverage_service in coverage_file_spec.

9426731

marklarr reviewed Oct 17, 2014
View reviewed changes

Julian Krumow added 7 commits October 17, 2014 13:33

More refactoring.

6f54abe

Use integer for line_number in branch_coverage_data. Use cleaned_gcov_data. Simplified collection operations. Ruby-ficated implementation of num_branches_testable and num_branches_tested. Add devision by zero checks.

Merge branch 'master' of https://github.com/venmo/slather

49b45de

Simplify implementation of #branch_coverage_data with regex.

9bce268

Extracts line of code with branch statement and all following "branch X taken / never excuted" annotations.

Rubify #branch_coverage_data even more.

1201803

Ditto.

a21563f

Cleanup code.

4682caa

Update coverage_file_spec.

fe0d9f8

marklarr added a commit that referenced this pull request Oct 21, 2014

Merge pull request #30 from tarbrain/master

3288ddb

Coverage Service for Cobertura XML

marklarr merged commit 3288ddb into SlatherOrg:master Oct 21, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Coverage Service for Cobertura XML #30

Coverage Service for Cobertura XML #30

jkrumow commented Oct 12, 2014

jkrumow commented Oct 16, 2014

ayanonagon Oct 16, 2014

jkrumow commented Oct 16, 2014

marklarr Oct 17, 2014

marklarr commented Oct 21, 2014

Coverage Service for Cobertura XML #30

Coverage Service for Cobertura XML #30

Conversation

jkrumow commented Oct 12, 2014

jkrumow commented Oct 16, 2014

ayanonagon Oct 16, 2014

Choose a reason for hiding this comment

jkrumow commented Oct 16, 2014

marklarr Oct 17, 2014

Choose a reason for hiding this comment

marklarr commented Oct 21, 2014