Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.clojure/tools.nrepl 0.2.12 to nrepl 0.5.3? #95

Closed
rux opened this issue Dec 13, 2018 · 6 comments · May be fixed by #96
Closed

Update org.clojure/tools.nrepl 0.2.12 to nrepl 0.5.3? #95

rux opened this issue Dec 13, 2018 · 6 comments · May be fixed by #96

Comments

@rux
Copy link

rux commented Dec 13, 2018

According to https://github.com/clojure/tools.nrepl, the active development of nREPL has moved to https://github.com/nrepl/nrepl earlier in 2018.

@cbcoutinho
Copy link

Possibly related technomancy/leiningen#2497 and technomancy/leiningen#2506

@bbatsov
Copy link

bbatsov commented Dec 14, 2018

Yes, the old project is no more. Refer to https://metaredux.com/posts/2018/10/29/nrepl-redux.html for more details. All projects should adopt the new package, as the main tooling already switched to it and tools like CIDER will just drop support for the old package very soon.

That's a simply way of supporting both versions https://github.com/clojure-emacs/cider-nrepl/blob/master/src/cider/nrepl.clj#L11

@bbatsov
Copy link

bbatsov commented Dec 14, 2018

@cbcoutinho Those bugs you refer to (which are the same bug actually) are unrelated to the need for updating the nREPL dep for ultra and similar packages.

@venantius
Copy link
Owner

We'll need greglook/whidbey#26 to go in first as otherwise Ultra will be on nREPL and our deps will be on clojure.tools.nrepl.

@narkisr
Copy link

narkisr commented Feb 7, 2019

Is this issue resolved yet?

As far as I can tell it was fixed in whidbey 2.0.0 but older dependency is still used in ultra 0.5.4

Thanks

@narkisr
Copy link

narkisr commented Feb 7, 2019

Trying to migrate to whidby 2.0.0 results with:

clojure.lang.Compiler$CompilerException: java.lang.RuntimeException: Unable to resolve var: whidbey.repl/printer in this context, compiling:(ultra/colorscheme.clj:62:5)

Looks like this is a breaking change

johannesloetzsch added a commit to johannesloetzsch/ultra that referenced this issue Feb 23, 2019
This was referenced Feb 23, 2019
@venantius venantius mentioned this issue Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants