feat: M2 — Daemon Pairing Store + HTTP Endpoints#8129
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9585c7ae56
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Add in-memory PairingStore for managing pairing request lifecycle, approved-devices-store for persisting device allowlist, and HTTP endpoints for the v4 pairing handshake (register, request, status). Wire pairing store into RuntimeHttpServer with IPC broadcast support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ashleeradka
force-pushed
the
simplify-pairing/m2
branch
from
9585c7a to
60f5f04
Compare
Contributor
Author
|
Addressed in #8189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the daemon-side pairing infrastructure: in-memory store, approved-devices persistence, IPC handler, and HTTP endpoints.
Changes
assistant/src/daemon/pairing-store.ts— In-memory store managing pairing request lifecycle (register, beginRequest, approve, deny, expiry)assistant/src/daemon/approved-devices-store.ts— SQLite-backed approved device allowlist with hash-based device IDsassistant/src/daemon/handlers/pairing.ts— IPC handler wiring pairing approval responses and device list managementassistant/src/daemon/handlers/index.ts— Registers pairing handlerassistant/src/runtime/http-server.ts— Adds /v1/pairing/register (authenticated), /v1/pairing/request (secret-gated), /v1/pairing/status (secret-gated) endpointsStack
M2 of 9 — Simplify Pairing + Mac Approval