From d68963572e06fdeba056b499f5d147f45ac691e7 Mon Sep 17 00:00:00 2001 From: Vellum Assistant Date: Sun, 3 May 2026 09:45:20 +0000 Subject: [PATCH] fix(computer-use): drop redundant activity field from core tool definitions PR #29374 removed the per-tool activity field from bundled-skill TOOLS.json but left it in assistant/src/tools/computer-use/definitions.ts. The result was that computer-use-skill-manifest-regression.test.ts > 'manifest input_schema matches core definitions' failed because the manifest no longer carried activity but the core definitions still did. Drop the field from the core definitions to restore parity with the manifest. --- .../src/tools/computer-use/definitions.ts | 22 ++----------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/assistant/src/tools/computer-use/definitions.ts b/assistant/src/tools/computer-use/definitions.ts index 32400fc4206..0d237092761 100644 --- a/assistant/src/tools/computer-use/definitions.ts +++ b/assistant/src/tools/computer-use/definitions.ts @@ -21,12 +21,6 @@ function proxyExecute(): Promise { ); } -const activityProperty = { - type: "string" as const, - description: - "Brief non-technical explanation of why this tool is being called", -}; - // --------------------------------------------------------------------------- // click (unified - click_type selects single / double / right) // --------------------------------------------------------------------------- @@ -69,7 +63,6 @@ export const computerUseClickTool: Tool = { description: "Explanation of what you see and why you are clicking here", }, - activity: activityProperty, }, required: ["reasoning"], }, @@ -106,7 +99,6 @@ export const computerUseTypeTextTool: Tool = { type: "string", description: "Explanation of what you are typing and why", }, - activity: activityProperty, }, required: ["text", "reasoning"], }, @@ -144,7 +136,6 @@ export const computerUseKeyTool: Tool = { type: "string", description: "Explanation of why you are pressing this key", }, - activity: activityProperty, }, required: ["key", "reasoning"], }, @@ -199,7 +190,6 @@ export const computerUseScrollTool: Tool = { type: "string", description: "Explanation of why you are scrolling", }, - activity: activityProperty, }, required: ["direction", "amount", "reasoning"], }, @@ -260,7 +250,6 @@ export const computerUseDragTool: Tool = { type: "string", description: "Explanation of what you are dragging and why", }, - activity: activityProperty, }, required: ["reasoning"], }, @@ -296,7 +285,6 @@ export const computerUseWaitTool: Tool = { type: "string", description: "Explanation of what you are waiting for", }, - activity: activityProperty, }, required: ["duration_ms", "reasoning"], }, @@ -335,7 +323,6 @@ export const computerUseOpenAppTool: Tool = { description: "Explanation of why you need to open or switch to this app", }, - activity: activityProperty, }, required: ["app_name", "reasoning"], }, @@ -373,7 +360,6 @@ export const computerUseRunAppleScriptTool: Tool = { description: "Explanation of what this script does and why AppleScript is better than UI interaction for this step", }, - activity: activityProperty, }, required: ["script", "reasoning"], }, @@ -406,7 +392,6 @@ export const computerUseDoneTool: Tool = { type: "string", description: "Human-readable summary of what was accomplished", }, - activity: activityProperty, }, required: ["summary"], }, @@ -443,7 +428,6 @@ export const computerUseRespondTool: Tool = { type: "string", description: "Explanation of how you determined the answer", }, - activity: activityProperty, }, required: ["answer", "reasoning"], }, @@ -471,10 +455,8 @@ const computerUseObserveTool: Tool = { description: this.description, input_schema: { type: "object", - properties: { - activity: activityProperty, - }, - required: ["activity"], + properties: {}, + required: [], }, }; },