fix(assistant): eliminate update-bulletin wake-resolver race + clean up orphans#26427
Merged
Merged
Conversation
… clean up orphans on invoked=false
Contributor
Author
|
Addressed in #26473 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runUpdateBulletinJobIfNeeded()is now dispatched AFTERDaemonServer.start()resolves, which is whereregisterDefaultWakeResolver()runs. The previous dispatch site ran concurrently with server startup, so the wake fired before the resolver was in place and silently returned{invoked: false}. The dispatch remains fire-and-forget (void import(...).then(...).catch(...)), preserving the 'daemon must never block startup' invariant.wakeAgentForOpportunity()can return{invoked: false}for other reasons (conversation-not-found, future regressions). The job now detects this and deletes the orphan background conversation it just bootstrapped, so we don't leak DB rows and LLM title-generation calls.Part of plan: updates-md-background-job.md (round 2 post-review fix)