fix: address review feedback from PR #25977#26422
Merged
Merged
Conversation
Addresses review feedback from #25977: - Move drainQueue() after tailMessages are pushed/persisted in agent-wake.ts so queued user messages are dequeued against up-to-date history - Revert build.sh default VELLUM_ENVIRONMENT back to local for run/fallback commands (was changed to dev, which would connect local builds to dev platform) - gmail-archive.ts blocklist fix was already landed in #25979, no action needed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drainQueue()to after tail messages are pushed and persisted, so concurrent sends dequeue against up-to-date history. Uses adrainedInTryflag so the finally block only handles error/early-return paths where no tail was produced.VELLUM_ENVIRONMENTforrunand fallback*commands back tolocal(was changed todev, which would connect local builds to dev platform instead of localhost).Addresses feedback from #25977.
Test plan
agent-wake.test.ts— all 16 tests pass including ordering invariant test🤖 Generated with Claude Code