fix(filing): emit active-hours refine issue on both fields#25673
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e50f8e4fed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Addressed in #25685 |
Jasonnnz
pushed a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Codex P1 on #25648.
When only one of
activeHoursStart/activeHoursEndis set,filing's (andheartbeat's)superRefinepreviously emitted the validation issue on the null/missing side. The config loader'svalidateWithSchemarepair deletesissue.pathand retries — but deleting a missing/defaulted key cannot resolve the mismatch, so the loader would fall through to a full-config reset.Fix: emit the issue on both field paths.
validateWithSchema's delete step strips whichever side was actually set (no-op on the null side), and the retry re-validates with both fields falling back to their schema defaults. This preserves unrelated user settings that would otherwise be reset to defaults.Heartbeat had the same buggy pattern — fixed it there too.
Added two loader-level regression tests covering both schemas: one for
filing(defaults null/null, user sets one side to a number) and one forheartbeat(defaults 8/22, user sets one side tonull). Both verify that an unrelated field (maxTokens: 4096) survives the repair, which proves no full-config reset occurred.