Skip to content

feat(memory): implement conversation_analyze job handler#25666

Merged
siddseethepalli merged 1 commit into
mainfrom
run-plan/auto-analyze-loop/pr-13
Apr 15, 2026
Merged

feat(memory): implement conversation_analyze job handler#25666
siddseethepalli merged 1 commit into
mainfrom
run-plan/auto-analyze-loop/pr-13

Conversation

@siddseethepalli

@siddseethepalli siddseethepalli commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Implement conversationAnalyzeJob handler that retrieves deps via the singleton and calls analyzeConversation(id, deps, { trigger: "auto" }).
  • Wire dispatch in jobs-worker.ts next to graph_extract.
  • Throws when deps aren't yet initialized so the worker reschedules.
  • Logs (does not throw) when the service rejects (e.g. recursion guard).

Part of plan: auto-analyze-loop.md (PR 13 of 15)


Open with Devin

@siddseethepalli siddseethepalli merged commit 5788f72 into main Apr 15, 2026
@siddseethepalli siddseethepalli deleted the run-plan/auto-analyze-loop/pr-13 branch April 15, 2026 01:41

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread assistant/src/memory/conversation-analyze-job.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 941be91fd0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/memory/conversation-analyze-job.ts
@siddseethepalli

Copy link
Copy Markdown
Contributor Author

Already addressed in #25676 (different approach): the handler now returns early when getAnalysisDeps is null, letting upstream triggers re-enqueue naturally instead of deferring. See the in-file comment in conversation-analyze-job.ts for the rationale (defer counters would still fail permanently in worst case; early return avoids retry storms during slow startup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant