refactor: rename stale HTTPDaemonClient test file to ConversationForkDecodingTests#21813
Merged
Merged
Conversation
…to ConversationForkDecodingTests Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
HTTPDaemonClientConversationForkDecodingTests.swift→ConversationForkDecodingTests.swiftand aligns the class name to match.HTTPDaemonClientwas removed from the codebase as part of the GatewayHTTPClient migration (#21729), leaving this test file with a stale name. The class inside had already been partially renamed toGatewayConnectionManagerConversationForkDecodingTests, but these tests actually decode shared model types (ConversationsListResponse,ConversationListResponse,ForkConversationResponse) — they aren't specific to any client or manager. The new name reflects what they actually test.No logic changes. Zero references to the old filename or class name exist elsewhere (verified via grep).
Review & Testing Checklist for Human
ConversationForkDecodingTestsis discovered and all 5 tests pass after the renameNotes
Link to Devin session: https://app.devin.ai/sessions/e19a9c46f61546368efaba6020397e17
Requested by: @ashleeradka