Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle on sales order #49

Open
joshribakoff opened this issue Jun 6, 2013 · 0 comments
Open

Vehicle on sales order #49

joshribakoff opened this issue Jun 6, 2013 · 0 comments

Comments

@joshribakoff
Copy link
Member

If you have a sales order come through it stores the ID of the vehicle. If the admin clears the schema & imports the fitments back in, that vehicle may have a new ID, so those orders may show the incorrect vehicle. I didn't think of this previously. I should probably store the name of the vehicle as a string instead of the ID of the vehicle.

Also if the vehicle is not found it throws an exception. I also need to rethink whether that situation should cause an exception/error, or just return null.

VF_Vehicle_Finder->findByLevel('model', 152433)
VF_Vehicle_Finder->findByLeaf(152433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant