Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions for Text Data Files #37

Open
5 tasks
BenjamenMeyer opened this issue Nov 3, 2021 · 6 comments
Open
5 tasks

GitHub Actions for Text Data Files #37

BenjamenMeyer opened this issue Nov 3, 2021 · 6 comments

Comments

@BenjamenMeyer
Copy link
Member

We need to add some GitHub Actions for some of the various tasks in this repository.
Some simple ones we should do on PRs:

I'm sure there's other things we'd like to do with the other functionality in here too. Actions should be mostly based around validating what might get changed.

@Loki1950
Copy link
Member

Loki1950 commented Nov 3, 2021

We should also consider a verification process for asset files as well and then there is the Python scripts too.

@BenjamenMeyer
Copy link
Member Author

@Loki1950 what tooling would we need for that?

BTW, I'm thinking each of these things could be separate actions for the PRs

@Loki1950
Copy link
Member

Loki1950 commented Nov 3, 2021

For the assets maybe just a sanity check and path verification the Python is more in your area of experience.

@BenjamenMeyer
Copy link
Member Author

The Python yes; that's pretty easy - I'm curious about the other stuff that's in here - images, sound, etc. - and what we should be doing to verify them. Are there format checkers? Can we validate audio streams? Verify we can process in text-to-audio?

@Loki1950
Copy link
Member

Loki1950 commented Nov 3, 2021

All of our images are in dds format ATM to keep our download and repo usage low though I will be keeping a local repo of our master images as well as blender files for each ship/installation which can be burned to disc for possible distribution to who ever requests it. One of things that has/is happening is those loading errors most are caused by path references being wrong or just not present in the csv files dropped or extra comma pyramid3d's UnitConverter does a good job for creating/checking the csv structure have used it for putting models in game and testing other things.

@romanyacik
Copy link
Contributor

I still want to help out, and even better, if I can start getting some coding exercise again. Is there anything trivial I can do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants