Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

".selector" deprecated on jQuery 1.9+ #283

Closed
subgurim opened this issue Feb 1, 2016 · 5 comments
Closed

".selector" deprecated on jQuery 1.9+ #283

subgurim opened this issue Feb 1, 2016 · 5 comments

Comments

@subgurim
Copy link

subgurim commented Feb 1, 2016

Hi!

Your (excellent) plugin uses lots of ".selector", which is deprecated as of jquery 1.9+.

So the plugin doesn't work for jQuery 1.9+

Any roadmap for this issue?

Thanks!

@vedmack
Copy link
Owner

vedmack commented Feb 1, 2016

Hi,

Where did you see that deprecation? I couldn't find any mentioning about it, and even on jquery official site it is used with a jquery-1.10.2 version, see here.

I think there is some other issue in your page... feel free to ask a question on stackoverflow.co

@vedmack vedmack closed this as completed Feb 1, 2016
@subgurim
Copy link
Author

subgurim commented Feb 1, 2016

Hi!

Thanks for your quick answer and sorry if I've not explained very well the issue.

Look at https://api.jquery.com/selector/ which is deprecated.

As far as I understand, this jQuery property is used in the plugin lots of times.

Please, excuse me if I'm wrong.

@vedmack
Copy link
Owner

vedmack commented Feb 1, 2016

You are right, .selector was deprecated since 1.7 but still present in the latest versions of jquery and yadcf is also working with the latest version of jquery without any problems.
Since this issue is related to #96 issue I will keep it closed and the moment I fix the #96 issue there will be no use of the selector at all...

@subgurim
Copy link
Author

subgurim commented Feb 1, 2016

Thanks!!

Only one remark, yadcf works for me if I don't use yadcf.init, except for "range-number" which uses ".selector" internally.

I'll suscribe for #96 waiting for a solution.

Thanks and great job!

@vedmack
Copy link
Owner

vedmack commented Feb 1, 2016

you should use yadcf.init only when you are using the capital D datatables constructor as to the range-number issue, I jsut checked with jquery-1.12.0 and it works just fine, so you can post a questoin on stackoverflow.com with a jsbin sample and I will see what went wrong there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants