From d935a5fbb4ae336d3576269febc7524db66d4729 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Boschi?= Date: Tue, 26 May 2026 14:50:41 +0200 Subject: [PATCH] fix(ci): align config field count and CLI consolidation call with #1746 PR #1746 added enable_auto_consolidation to _CONFIGURABLE_FIELDS and introduced a ConsolidationRequest body on the /consolidate endpoint, but didn't update test_hierarchical_fields_categorization (still expects 35 fields) or the CLI's trigger_consolidation wrapper (still calls the generated client with 2 args), so CI on this branch breaks on test-api, test-rust-cli, test-embed-windows, and test-doc-examples (cli). Bump the expected count to 36, add enable_auto_consolidation to the explicit assertions, and pass a default ConsolidationRequest to the generated client so the no-scope CLI invocation keeps consolidating all unconsolidated memories. --- hindsight-api-slim/tests/test_hierarchical_config.py | 3 ++- hindsight-cli/src/api.rs | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hindsight-api-slim/tests/test_hierarchical_config.py b/hindsight-api-slim/tests/test_hierarchical_config.py index 0cb838a6da..4e6ba68e25 100644 --- a/hindsight-api-slim/tests/test_hierarchical_config.py +++ b/hindsight-api-slim/tests/test_hierarchical_config.py @@ -124,9 +124,10 @@ async def test_hierarchical_fields_categorization(): assert "llm_gemini_safety_settings" in configurable assert "mcp_enabled_tools" in configurable assert "retain_chunk_batch_size" in configurable + assert "enable_auto_consolidation" in configurable # Verify count is correct - assert len(configurable) == 35 + assert len(configurable) == 36 # Verify credential fields (NEVER exposed) assert "llm_api_key" in credentials diff --git a/hindsight-cli/src/api.rs b/hindsight-cli/src/api.rs index dce453652a..9f71636c4f 100644 --- a/hindsight-cli/src/api.rs +++ b/hindsight-cli/src/api.rs @@ -953,7 +953,11 @@ impl ApiClient { _verbose: bool, ) -> Result { self.runtime.block_on(async { - let response = self.client.trigger_consolidation(bank_id, None).await?; + let body = types::ConsolidationRequest::default(); + let response = self + .client + .trigger_consolidation(bank_id, None, &body) + .await?; Ok(response.into_inner()) }) }