Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quote text is too dark on dark theme #5154

Closed
ara4n opened this issue Oct 3, 2017 · 5 comments · Fixed by matrix-org/matrix-react-sdk#5353
Closed

quote text is too dark on dark theme #5154

ara4n opened this issue Oct 3, 2017 · 5 comments · Fixed by matrix-org/matrix-react-sdk#5353
Labels
A-Theming P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users

Comments

@ara4n
Copy link
Member

ara4n commented Oct 3, 2017

i fixed this at some point but someone must have broken it again
@turt2live turt2live mentioned this issue Oct 3, 2017
Closed
41 tasks
@lampholder lampholder added S-Tolerable Low/no impact on users A-Theming P2 S-Minor Impairs non-critical functionality or suitable workarounds exist easy labels Oct 4, 2017
@lampholder
Copy link
Member

image
Setting P2 minor 'cause it looks to me to be annoyingly dark rather than enragingly/unusably dark :)

@aidalgol aidalgol mentioned this issue Apr 15, 2018
Closed
@bhauer
Copy link

bhauer commented Jul 29, 2020

Would really appreciate this one getting bumped in priority. My older eyes struggle to read quoted text in the dark theme, and the alternative of using the light theme is simply not an option since that causes a totally different and worse eye strain. Thanks!

@lilyCalla
Copy link

I could be missing something, but in new version this looks like it may have been fixed. Quotes appear to now be the same color as the original post.
blocktest

@t3chguy
Copy link
Member

t3chguy commented Sep 6, 2020

That's a reply, not a quote

@t3chguy
Copy link
Member

t3chguy commented Sep 7, 2020

image

@resynth1943 resynth1943 mentioned this issue Oct 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Theming P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lighten blockquote colour in dark mode
Lighten <blockquote> in dark theme
5 participants
@bhauer @ara4n @lampholder @t3chguy @lilyCalla