Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's surprising that we instantly send an RR on opening a room #2422

Open
ara4n opened this issue Apr 18, 2017 · 4 comments
Open

It's surprising that we instantly send an RR on opening a room #2422

ara4n opened this issue Apr 18, 2017 · 4 comments

Comments

@ara4n
Copy link
Member

ara4n commented Apr 18, 2017

I'd have expected that we waited a few 100ms to give the user to actually read something before proudly sending an RR. Looks like it's been like this since day 1 though: matrix-org/matrix-react-sdk@86ef0e7#diff-f9ae5a2c997a9381f2547c128b066592R178. I just spent a while tracking this down as it felt weird enough to be a regression

@lampholder
Copy link
Member

Is the concern just that this looks weird to other users in the room? Seeing X join and then immediately X has read everything?

It risks being even weirder if we implement a universal 'fake reading time' - at least if the two events happen instantaneously we know the user hasn't really read anything at the marker is just showing what's appeared on their screen.

@lampholder lampholder added S-Tolerable Low/no impact on users P3 labels Apr 20, 2017
@lukebarnard1
Copy link

Seeing X join and then immediately X has read everything?

I think this is a different issue. The title reads "opening", not "joining".

Possible solution: setTimeout on sending every RR? I'm thinking the 100ms would get washed out by network latency (and also, would anyone really notice?)

@lampholder
Copy link
Member

Ah yes, you're right - thanks.

I'm also of the opinion that people aren't likely to notice. It's a pretty subtle refinement - one that's worth considering in the future, though.

@MightyCreak
Copy link

To reiterate what I told in element-hq/element-web#6386, I think 100 ms is too short. I think the app should wait a certain amount of time (e.g. 2 seconds) before acknowledging the read receipt. Let some time for the users to decide if this is the right room or not.

@t3chguy t3chguy transferred this issue from element-hq/element-web May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants