Copy tweaks to demystify guests in room settings

[nadonomy]

& sanity check other parts of the app too.

Related: #16113

[niquewoodhouse]

Some options based around the idea this is a papercut, so the solution needs to be quite small and not introducing more papercuts. Obviously, input needed to identify what's actually demystifying guests and not introducing more issues.

On first inspection of a room, the most obvious places where 'guests' is shown is the room timeline (when someone changes access) and the room settings, so I've looked at both. I've used a DM context when looking at a room timeline because that's where guest access is possibly most problematic.

Settings is currently this:

Room timeline is currently this (minus the 'you' bit)

---

Options:

0 Amend existing settings options

The use of guests in both lines means you have to really read to understand the difference, but the difference isn't explained.

1a Add tooltip to guests in settings

1b Add tooltip to guest references in room timeline, and edit copy to say "guest access" instead of "allowed guests to join the room"

There isn't much space in a tooltip for anything complicated/long.

2a Expose explanation by default in settings

2b Highlight information in room timeline

3a Separate guests from access basic section in settings

The advanced interaction comes from settings > appearance.

This would mean that the room timeline doesn't show 'guest access' things so often, as one button isn't being used to set guest access, and other access. This might be introducing a lot of change though/random new things.

[t3chguy]

Modifying the timeline here beyond copy (adding tooltips etc) will be tricky as the code is reused for notifications generation so it has to output plaintext.

Any of the settings changes are sane,

Putting Unlisted/Public in the same option feels disjoint as to by that definition of public the room must have an Address, but you manage those on the General tab

[niquewoodhouse]

Modifying the timeline here beyond copy (adding tooltips etc) will be tricky as the code is reused for notifications generation so it has to output plaintext.

Great, I think this might make sense then, as it's just changing copy. Exact copy tbc

[t3chguy]

adding gloss/tooltip in settings is no problem ftr