Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Rust Crypto for all users #7485

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Apr 11, 2023

In this final stage of Rust Crypto rollout enable the feature to all users. The feature flags mechanism and other now-unnecessary code will be removed in future PRs

Note that this change will be released as "hotfix" to only contain the target percentage change and no other features

@Anderas Anderas requested review from a team and pixlwave and removed request for a team April 11, 2023 11:08
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (hotfix/1.10.9@9b2c7a6). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##             hotfix/1.10.9    #7485   +/-   ##
================================================
  Coverage                 ?   12.29%           
================================================
  Files                    ?     1645           
  Lines                    ?   163155           
  Branches                 ?    66992           
================================================
  Hits                     ?    20066           
  Misses                   ?   142439           
  Partials                 ?      650           
Flag Coverage Δ
uitests 55.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bhauer
Copy link

bhauer commented Jul 7, 2023

FYI: This has been cited as potentially causing an issue when iOS clients send (a) a photo followed by (b) a text message. See issues #24267 and #25221 on element-web:

element-hq/element-web#24267
element-hq/element-web#25221

Desktop clients will be unable to decrypt the (b) text, instead seeing "unable to decrypt message."

The situation can apparently escalate via an unknown sequence to cause severe encryption problems in the channel over time. I have one channel between just two users who have always trusted one another devolve into permanent cryptography failure. These users are both iOS+desktop users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants