-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user suggestions for @room. #7453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what caused this to only get updated just now? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everyone has been ignoring this for ages, so I just decided to commit it now.
RiotSwiftUI/Modules/Room/UserSuggestion/Coordinator/UserSuggestionCoordinator.swift
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7453 +/- ##
===========================================
- Coverage 12.30% 12.29% -0.01%
===========================================
Files 1645 1645
Lines 162982 163011 +29
Branches 66914 66925 +11
===========================================
+ Hits 20048 20049 +1
- Misses 142285 142312 +27
- Partials 649 650 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
When typing
@room
in a room where you have the power, a suggestion will now be shown. Also converts@everyone
to@room
too. Additionally, incoming messages containing the text@room
will be highlighted in encrypted rooms now too. Requires matrix-org/matrix-ios-sdk#1750Closes https://github.com/vector-im/customer-retainer/issues/23