Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user suggestions for @room. #7453

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Add user suggestions for @room. #7453

merged 3 commits into from
Mar 28, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Mar 27, 2023

When typing @room in a room where you have the power, a suggestion will now be shown. Also converts @everyone to @room too. Additionally, incoming messages containing the text @room will be highlighted in encrypted rooms now too. Requires matrix-org/matrix-ios-sdk#1750

Closes https://github.com/vector-im/customer-retainer/issues/23

With power levels Without power levels
Simulator Screen Recording - iPhone 14 - 2023-03-27 at 12 48 08 Simulator Screen Recording - iPhone 14 - 2023-03-27 at 16 18 42

@pixlwave pixlwave requested review from a team and stefanceriu and removed request for a team March 27, 2023 15:38
@pixlwave pixlwave marked this pull request as ready for review March 27, 2023 15:47
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what caused this to only get updated just now? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everyone has been ignoring this for ages, so I just decided to commit it now.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 11.62% and project coverage change: -0.01 ⚠️

Comparison is base (6e48692) 12.30% compared to head (cd44f09) 12.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7453      +/-   ##
===========================================
- Coverage    12.30%   12.29%   -0.01%     
===========================================
  Files         1645     1645              
  Lines       162982   163011      +29     
  Branches     66914    66925      +11     
===========================================
+ Hits         20048    20049       +1     
- Misses      142285   142312      +27     
- Partials       649      650       +1     
Flag Coverage Δ
uitests 55.24% <83.33%> (+<0.01%) ⬆️
unittests 6.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...estion/Coordinator/UserSuggestionCoordinator.swift 0.00% <0.00%> (ø)
.../Coordinator/UserSuggestionCoordinatorBridge.swift 0.00% <0.00%> (ø)
...UserSuggestion/Service/UserSuggestionService.swift 74.60% <80.00%> (+0.02%) ⬆️
...oom/UserSuggestion/UserSuggestionScreenState.swift 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave merged commit 71a69d0 into develop Mar 28, 2023
@pixlwave pixlwave deleted the doug/at-room branch March 28, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants