Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SwiftPM for AnalyticsEvents instead of CocoaPods #7401

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Mar 2, 2023

Resolves https://github.com/vector-im/crypto-internal/issues/32

Once integrated, use newly added crypto module property to distinguish E2EE errors.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making this change to SwiftPM Andy 🙏

@pixlwave
Copy link
Member

pixlwave commented Mar 2, 2023

Oh small thought, probably worth updating the documentation for the analytics class.

@Anderas
Copy link
Contributor Author

Anderas commented Mar 2, 2023

Oh small thought, probably worth updating the documentation for the analytics class.

Good call, though I am mostly deleting it as its sufficiently documented in the analytics repo.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 23.07% and no project coverage change

Comparison is base (9441f69) 12.15% compared to head (b1cd12a) 12.15%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7401   +/-   ##
========================================
  Coverage    12.15%   12.15%           
========================================
  Files         1643     1642    -1     
  Lines       162310   162301    -9     
  Branches     66647    66645    -2     
========================================
- Hits         19728    19727    -1     
+ Misses      141937   141929    -8     
  Partials       645      645           
Flag Coverage Δ
uitests 55.31% <ø> (-0.03%) ⬇️
unittests 6.01% <23.07%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Analytics/Analytics.swift 12.71% <0.00%> (-0.29%) ⬇️
...iot/Modules/Analytics/PostHogAnalyticsClient.swift 71.87% <100.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...tartLocationSharing/View/LocationSharingView.swift 57.51% <0.00%> (+0.65%) ⬆️
...tartLocationSharing/LocationSharingViewModel.swift 9.27% <0.00%> (+0.66%) ⬆️
...haringViewer/LiveLocationSharingViewerModels.swift 13.33% <0.00%> (+6.66%) ⬆️
...nSharing/MapView/View/LocationSharingMapView.swift 56.63% <0.00%> (+7.96%) ⬆️
...ionSharingViewer/StaticLocationViewingModels.swift 33.33% <0.00%> (+16.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas merged commit 0a95389 into develop Mar 6, 2023
@Anderas Anderas deleted the andy/analytics branch March 6, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants