-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SwiftPM for AnalyticsEvents instead of CocoaPods #7401
Conversation
0e6e9f2
to
a6fc7c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making this change to SwiftPM Andy 🙏
Oh small thought, probably worth updating the documentation for the analytics class. |
Good call, though I am mostly deleting it as its sufficiently documented in the analytics repo. |
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7401 +/- ##
========================================
Coverage 12.15% 12.15%
========================================
Files 1643 1642 -1
Lines 162310 162301 -9
Branches 66647 66645 -2
========================================
- Hits 19728 19727 -1
+ Misses 141937 141929 -8
Partials 645 645
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Resolves https://github.com/vector-im/crypto-internal/issues/32
Once integrated, use newly added crypto module property to distinguish E2EE errors.