Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide old sessions list when the new dm is enabled (PSG-830) #6999

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

alfogrillo
Copy link
Contributor

Description

This PR hides the old session list when the new device manager is enabled.

poc

@alfogrillo alfogrillo requested review from a team and stefanceriu and removed request for a team October 27, 2022 14:34
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 11.75% // Head: 11.74% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (ac0f6a1) compared to base (ee43a27).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6999      +/-   ##
===========================================
- Coverage    11.75%   11.74%   -0.02%     
===========================================
  Files         1607     1607              
  Lines       157891   157869      -22     
  Branches     63827    63820       -7     
===========================================
- Hits         18564    18534      -30     
- Misses      138698   138706       +8     
  Partials       629      629              
Flag Coverage Δ
uitests 54.51% <ø> (-0.24%) ⬇️
unittests 6.10% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Modules/Settings/Security/SecurityViewController.m 0.00% <0.00%> (ø)
...s/UserSessionDetails/View/UserSessionDetails.swift 0.00% <0.00%> (-85.72%) ⬇️
...erSessionDetails/View/UserSessionDetailsItem.swift 0.00% <0.00%> (-50.95%) ⬇️
.../UserSessionDetails/UserSessionDetailsModels.swift 0.00% <0.00%> (-36.37%) ⬇️
...otSwiftUI/Modules/Common/Util/ListBackground.swift 88.00% <0.00%> (ø)
...rOtherSessions/View/UserOtherSessionsToolbar.swift 93.65% <0.00%> (+3.17%) ⬆️
...linePoll/View/TimelinePollAnswerOptionButton.swift 54.62% <0.00%> (+8.52%) ⬆️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 90.00% <0.00%> (+9.87%) ⬆️
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 90.19% <0.00%> (+10.95%) ⬆️
...ns/UserOtherSessions/UserOtherSessionsFilter.swift 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit 11c388c into develop Oct 27, 2022
@alfogrillo alfogrillo deleted the alfogrillo/hide_old_session_manager branch October 27, 2022 15:27
@alfogrillo alfogrillo changed the title Hide old sessions list when the new dm is enabled (PSG-716) Hide old sessions list when the new dm is enabled (PSG-830) Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants