Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define MXCrypto and MXCrossSigning as protocols #6943

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Oct 20, 2022

See related SDK change

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pSLbZU

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 11.74% // Head: 11.76% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (170f265) compared to base (ac6c8f0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6943      +/-   ##
===========================================
+ Coverage    11.74%   11.76%   +0.01%     
===========================================
  Files         1592     1607      +15     
  Lines       156624   157840    +1216     
  Branches     63250    63750     +500     
===========================================
+ Hits         18396    18565     +169     
- Misses      137607   138647    +1040     
- Partials       621      628       +7     
Flag Coverage Δ
uitests 54.75% <ø> (-0.14%) ⬇️
unittests 6.10% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Application/LegacyAppDelegate.m 14.49% <ø> (-0.01%) ⬇️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 13.53% <0.00%> (+0.30%) ⬆️
...Modules/Settings/Security/SecurityViewController.m 0.00% <0.00%> (ø)
...es/Room/Composer/ViewModel/ComposerViewModel.swift 53.84% <0.00%> (-12.83%) ⬇️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 89.58% <0.00%> (-0.62%) ⬇️
.../TimelineCells/Common/MXKRoomBubbleTableViewCell.m 0.29% <0.00%> (-0.01%) ⬇️
Config/BuildSettings.swift 43.07% <0.00%> (ø)
Riot/Categories/UITableViewCell.swift 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomCoordinator.swift 0.00% <0.00%> (ø)
... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pixlwave
Copy link
Member

Although looks like there might be some more updates to make in the Tests 🙃

Base automatically changed from andy/trust_devices to develop October 25, 2022 13:07
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Anderas Anderas merged commit d38e312 into develop Oct 25, 2022
@Anderas Anderas deleted the andy/crypto_protocol branch October 25, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants