-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define MXCrypto and MXCrossSigning as protocols #6943
Conversation
7780810
to
1f947d8
Compare
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pSLbZU |
Codecov ReportBase: 11.74% // Head: 11.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6943 +/- ##
===========================================
+ Coverage 11.74% 11.76% +0.01%
===========================================
Files 1592 1607 +15
Lines 156624 157840 +1216
Branches 63250 63750 +500
===========================================
+ Hits 18396 18565 +169
- Misses 137607 138647 +1040
- Partials 621 628 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Although looks like there might be some more updates to make in the Tests 🙃 |
1f947d8
to
170f265
Compare
Kudos, SonarCloud Quality Gate passed! |
See related SDK change