Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes are not working when the new WYSIWYG is enabled #7691

Closed
giomfo opened this issue Oct 3, 2023 · 1 comment · Fixed by #7713
Closed

Quotes are not working when the new WYSIWYG is enabled #7691

giomfo opened this issue Oct 3, 2023 · 1 comment · Fixed by #7713
Assignees
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs

Comments

@giomfo
Copy link
Member

giomfo commented Oct 3, 2023

Steps to reproduce

  1. Enable the new WYSIWYG editor in the application settings
  2. Select a message in an existing room timeline
  3. Select the option "Quote"

Outcome

What did you expect?

The quoted message should appear in the composer and be sent with the new message

What happened instead?

nothing appears in the composer, the quoted message is missing in the new sent message

Additional information:

  • This issue has been filed in matrix-rich-text-editor repo. But I didn't reproduce it in Element-Android v1.6.5
  • This issue is reproduced on Element-web

Your phone model

No response

Operating system version

No response

Application version

1.11.4

Homeserver

No response

Will you send logs?

No

@giomfo giomfo added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 3, 2023
@Velin92 Velin92 added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor labels Oct 16, 2023
@giomfo giomfo self-assigned this Oct 26, 2023
@giomfo
Copy link
Member Author

giomfo commented Oct 26, 2023

I investigated this issue:

  • first in Element-Android, the quote is handled by using a dedicated sending mode UI (like Reply or Edit):
image

The selected message text is not displayed in the composer, it is added to the typed message during the sending process:
image

  • About Element-iOS, quotes are not working with WYSIWYG, because the existing code doesn't support the RTE use case here, contrary to the edition (see here)

  • I tested to fill the selected message body in the composer by setting a htmlContent. But this failed, I observed the following error Provided HTML index is out of expected bounds as soon as the provided string has a html tag (<blockquote> for example)

  • one option would be to apply an action (.quote) to the composer by using this method, but before, an update of the rich-text-editor seems relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs
Projects
Status: Closed
Status: Merged
Development

Successfully merging a pull request may close this issue.

2 participants