-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcast Upload Extension #7566
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7566 +/- ##
===========================================
- Coverage 12.36% 12.22% -0.15%
===========================================
Files 1648 1648
Lines 163581 163591 +10
Branches 67170 67156 -14
===========================================
- Hits 20226 19992 -234
- Misses 142690 142954 +264
+ Partials 665 645 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, with the point noted offline about the license/copyright headers in the files from the Jitsi sample app.
Kind of a shame to have some of that unsafe code added, but we know it works so 🤷♂️
BroadcastUploadExtension/SupportingFiles/BroadcastUploadExtension.entitlements
Outdated
Show resolved
Hide resolved
Co-authored-by: Doug <[email protected]>
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XLD51y |
The PR is ready the only thing left to do is understand how to deal with the copyright notices, considering that the SDK guide itself suggested to import the files, and that the original repo has the following Apache LICENSE I did some modifications in the SampleHandler but nothing too major in the other files. |
Kudos, SonarCloud Quality Gate passed! |
This allows to screen share your screen by using Jitsi screen share feature.