Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast Upload Extension #7566

Merged
merged 15 commits into from
Jun 1, 2023
Merged

Broadcast Upload Extension #7566

merged 15 commits into from
Jun 1, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented May 31, 2023

This allows to screen share your screen by using Jitsi screen share feature.

@Velin92 Velin92 added the Trigger-PR-Build Label to trigger builds for PRs label May 31, 2023
@Velin92 Velin92 requested review from manuroe and pixlwave May 31, 2023 13:25
@Velin92 Velin92 linked an issue May 31, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (94d19d4) 12.36% compared to head (3c5bae9) 12.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7566      +/-   ##
===========================================
- Coverage    12.36%   12.22%   -0.15%     
===========================================
  Files         1648     1648              
  Lines       163581   163591      +10     
  Branches     67170    67156      -14     
===========================================
- Hits         20226    19992     -234     
- Misses      142690   142954     +264     
+ Partials       665      645      -20     
Flag Coverage Δ
uitests 55.05% <ø> (-0.01%) ⬇️
unittests 6.06% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Integrations/Widgets/Jitsi/JitsiViewController.m 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, with the point noted offline about the license/copyright headers in the files from the Jitsi sample app.

Kind of a shame to have some of that unsafe code added, but we know it works so 🤷‍♂️

BroadcastUploadExtension/Common.xcconfig Outdated Show resolved Hide resolved
BroadcastUploadExtension/target.yml Show resolved Hide resolved
BroadcastUploadExtension/Sources/SampleHandler.swift Outdated Show resolved Hide resolved
BroadcastUploadExtension/Sources/SampleHandler.swift Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 31, 2023

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XLD51y

@Velin92
Copy link
Member Author

Velin92 commented Jun 1, 2023

The PR is ready the only thing left to do is understand how to deal with the copyright notices, considering that the SDK guide itself suggested to import the files, and that the original repo has the following Apache LICENSE
https://github.com/jitsi/jitsi-meet-sdk-samples/blob/master/LICENSE

I did some modifications in the SampleHandler but nothing too major in the other files.

@manuroe

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Velin92 Velin92 merged commit c87b8e2 into develop Jun 1, 2023
@Velin92 Velin92 deleted the mauroromito/broadcast_extension branch June 1, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Label to trigger builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a Broadcast Upload Extension to Element
2 participants