Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading of .opus Files Causes App Crash #6584

Closed
chrissphinx opened this issue Aug 17, 2022 · 8 comments · Fixed by #6720
Closed

Loading of .opus Files Causes App Crash #6584

chrissphinx opened this issue Aug 17, 2022 · 8 comments · Fixed by #6720
Labels
A-Media crash O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@chrissphinx
Copy link

chrissphinx commented Aug 17, 2022

Steps to reproduce

Attempt to load any channel with .opus files uploaded to it. Alternatively: already be in a channel where someone posts a .opus file and the app will immediately crash.

Outcome

comp_crash.mp4

What did you expect?

Not to crash.

What happened instead?

The app crashed.

Your phone model

iPhone XS

Operating system version

iOS 15.6

Application version

Element 1.8.27

Homeserver

Synapse 1.12

Will you send logs?

Yes

@chrissphinx chrissphinx added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 17, 2022
@chrissphinx
Copy link
Author

Other users on Android do not have this issue.

@pixlwave
Copy link
Member

Hi @chrissphinx, thanks for your report. I have just tried this and was unable to reproduce it with the file I tested. Would you able to share the opus file that caused this issue (or if sensitive, another file that also causes it)?

@pixlwave pixlwave added crash A-Media S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow X-Needs-Info This issue is blocked pending further information from the reporter labels Aug 22, 2022
@n8pjl
Copy link

n8pjl commented Aug 26, 2022

A user on my homeserver reported this same issue (or something similar) on v1.8.27. The file in question was uploaded via the voice message on element-desktop v1.11.2 and caused the app to crash when loading that particular room (an encrypted DM in this case.) The room loads messages (including the opus file) but appears to not finish syncing before crashing very soon after. Voice messages from that user on ios did not trigger this crash, nor did messages from an android client. I have not tried to reproduce this crash as I do not have access to an iphone myself, but can continue testing later tomorrow. I cannot submit the offending file as I deleted it to determine if it was the issue, which promptly fixed the problem.

Sorry about the chaotic bug report. It's been a long day and more matrix/element issues never help.

@chrissphinx
Copy link
Author

chrissphinx commented Aug 28, 2022

@pixlwave I can't actually attach the file here because .opus files are not supported by GitHub, but one of our members is rehosting the file here: https://dogspluspl.us/fastslow.opus

I can load and play this fine on Element Nightly for macOS (I'm on an M1) and also on web under Firefox on Windows. As soon as I upload this file, if it is to a room I have opened on Element on iOS, the iOS application will immediately crash. From there it exhibits same behavior as above until offending message is removed and then it works as expected again.

@b401
Copy link

b401 commented Sep 8, 2022

Same exact issue described here but with .ogg files from voice messages.

I'm on iOS 15.6.1 (X) | Element 1.9.2 (20220831174135)

@MonsieurLanza
Copy link

MonsieurLanza commented Sep 8, 2022

Same issue here, on an unencrypted room, iOS 15.6.1, element 1.9.2 (20220831174135).
Ogg message recorded from element-web or desktop.

@dud1337
Copy link

dud1337 commented Sep 8, 2022

Same exact issue described here but with .ogg files from voice messages.

I'm on iOS 15.6.1 (X) | Element 1.9.2 (20220831174135)

I've noticed some people weaponising this.

@MonsieurLanza
Copy link

MonsieurLanza commented Sep 8, 2022

While adding enough messages to the room to get the offending message out of sight, element can re-open the room. But when scrolling up in history, as soon as the voice message appears in the view, app crashes. Something wrong with the player ?

@pixlwave pixlwave added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow X-Needs-Info This issue is blocked pending further information from the reporter labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Media crash O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants