Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create fallback turn server option #5781

Closed

Conversation

CicadaCinema
Copy link

Fixes #2329
Fixes #3063

PR Moved from #4391

Screenshot

You need to enable the fallback option in Settings > Voice & Video to use this feature.
Screenshot_20211106-215730_Element dbg.png

@CicadaCinema
Copy link
Author

I've addressed the comments in #4391 (apart from proactively asking the user to turn this option on if their homeserver has no ice server config) and moved this to a new branch - hence the new PR.

@CicadaCinema
Copy link
Author

@BillCarsonFr @bmarty

@ouchadam ouchadam added the Z-Community-PR Issue is solved by a community member's PR label Apr 19, 2022
@bmarty bmarty requested a review from BillCarsonFr June 15, 2022 19:54
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK now, WDYT @BillCarsonFr ?

@@ -548,6 +548,8 @@
<string name="settings_call_category">Calls</string>
<string name="settings_call_show_confirmation_dialog_title">Prevent accidental call</string>
<string name="settings_call_show_confirmation_dialog_summary">Ask for confirmation before starting a call</string>
<string name="settings_call_ringtone_use_default_stun_title">Allow fallback call assist server</string>
<string name="settings_call_ringtone_use_default_stun_summary">Will use %s as assist when your homeserver does not offer one (your IP address will be seen by the stun server during a call)</string>
Copy link
Member

@bmarty bmarty Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ringtone is a bit strange here (for the 2 string keys), probably coming from a copy/paste :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ringtone is a bit strange here (for the 2 string keys), probably coming from a copy/paste :)

Yes, I copied the string keys from the old riot-android repo:

https://github.com/vector-im/riot-android/blob/a763655c54c4e465d2ae81e3ecd6a5146564771f/vector/src/main/res/values/strings.xml#L349-L350

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
4 participants