-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create fallback turn server option #5781
Conversation
I've addressed the comments in #4391 (apart from proactively asking the user to turn this option on if their homeserver has no ice server config) and moved this to a new branch - hence the new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK now, WDYT @BillCarsonFr ?
@@ -548,6 +548,8 @@ | |||
<string name="settings_call_category">Calls</string> | |||
<string name="settings_call_show_confirmation_dialog_title">Prevent accidental call</string> | |||
<string name="settings_call_show_confirmation_dialog_summary">Ask for confirmation before starting a call</string> | |||
<string name="settings_call_ringtone_use_default_stun_title">Allow fallback call assist server</string> | |||
<string name="settings_call_ringtone_use_default_stun_summary">Will use %s as assist when your homeserver does not offer one (your IP address will be seen by the stun server during a call)</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ringtone
is a bit strange here (for the 2 string keys), probably coming from a copy/paste :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ringtone
is a bit strange here (for the 2 string keys), probably coming from a copy/paste :)
Yes, I copied the string keys from the old riot-android repo:
|
Fixes #2329
Fixes #3063
PR Moved from #4391
Screenshot
You need to enable the fallback option in
Settings > Voice & Video
to use this feature.