Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent permission usage in client methods #368

Closed
mmeloni opened this issue Jul 3, 2020 · 0 comments · Fixed by #438
Closed

Inconsistent permission usage in client methods #368

mmeloni opened this issue Jul 3, 2020 · 0 comments · Fixed by #438
Assignees
@mmeloni
Labels
bug Something isn't working Component::immudb Server component of immudb design Design decisions documentation Improvements or additions to documentation Feature::multidb Multi database support
Milestone
v0.7

Comments

@mmeloni
Copy link
Contributor

mmeloni commented Jul 3, 2020 •
edited
Loading

User permission usage should be uniform
What happened
In SetPermission we use byte[] type and in ChangePermission there is a Permission type
What you expected to happen
I should see a single pattern
How to reproduce it (as minimally and precisely as possible)

Environment
immudb 0.6.2
Commit : 035845e
Built by: [email protected]
Built at: Thu, 02 Jul 2020 10:25:28 CEST

Additional info (any other context about the problem)
@mmeloni mmeloni added bug Something isn't working Component::immudb Server component of immudb design Design decisions documentation Improvements or additions to documentation labels Jul 3, 2020
@padurean padurean added the Feature::multidb Multi database support label Jul 27, 2020
@vchain-us-mgmt vchain-us-mgmt added this to the v0.7 milestone Jul 27, 2020
mmeloni added a commit that referenced this issue Jul 31, 2020
@mmeloni
refactor: handle in idiomatic way errors in changePermission grpc ser…
4635f9c 
…vice. Fixes #368

Signed-off-by: Michele Meloni <[email protected]>
mmeloni added a commit that referenced this issue Jul 31, 2020
@mmeloni
refactor: handle in idiomatic way errors in changePermission grpc ser…
a30de3c 
…vice. Fixes #368

Signed-off-by: Michele Meloni <[email protected]>
@mmeloni mmeloni linked a pull request Jul 31, 2020 that will close this issue
improving error handling #438
Merged
mmeloni added a commit that referenced this issue Aug 2, 2020
@mmeloni
refactor: handle in idiomatic way errors in changePermission grpc ser…
8a01e46 
…vice. Fixes #368

Signed-off-by: Michele Meloni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmeloni mmeloni

Labels
bug Something isn't working Component::immudb Server component of immudb design Design decisions documentation Improvements or additions to documentation Feature::multidb Multi database support
Projects
None yet
Milestone
v0.7
Development

Successfully merging a pull request may close this issue.

improving error handling codenotary/immudb
3 participants
@padurean @mmeloni @vchain-us-mgmt