Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatCompletionClient interface change #1

Open
jackgerrits opened this issue Dec 30, 2024 · 3 comments
Open

ChatCompletionClient interface change #1

jackgerrits opened this issue Dec 30, 2024 · 3 comments

Comments

@jackgerrits
Copy link

I wanted to let you know that we just merged a small change to the ChatCompletionClient interface microsoft/autogen#4856

The effect on your lib is minimal. To update your code to match the new expected parameter to the OpenAIChatCompletionClient you should update the following line:

model_capabilities: Optional[ModelCapabilities] = None,

to:

model_info: Optional[ModelInfo] = None,

Then pass this value to themodel_info param of the parent.

Let me know if you have any questions!

@jackgerrits
Copy link
Author

I went to open a PR but noticed that it conflicts with a model_info parameter you currently have so wanted to let you decide how to handle.

@vballoli
Copy link
Owner

Sorry missed this issue before archiving: I noticed that your PR provides support to pass all the OpenAI-LLM-call arguments directly through the ModelFamily and base_url args - which kind of makes this repo redundant (I could add a few classes that inherit the 0.4.dev13 OpenAIClient version that support all the other popular LLMs out there which could be useful to others to minimize efforts), but seems like largely your PR removes the necessity of this repo. Curious if you think the same

@jackgerrits
Copy link
Author

Personally, I think there is value in what you're doing here. That is maintaining model info and providing easy to use wrappers for people choosing specific providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants