Node 8 recommended on "From the sources"

[HelderFSFerreira]

The node version recommended on "From the sources" is 8. Is that still correct?

Context

• XO origin: the sources / XO Appliance
• Versions:
  • Node: N/A
  • xo-web: N/A
  • xo-server: N/A

Expected behavior

Recommend a not deprecated version of nodeJS

Current behavior

Recommending a deprecated version of nodeJS

[julien-f]

It was correct since very recently, it should work with latest Node LTS now but we'll make some tests before officially migrating :-)

[julien-f]

@HelderFSFerreira No problem, thank you for your tests and feedback 🙂

[Danp2]

When switching from Node 8 to LTS (Node 12.16.1), the build process is failing when the VM has only 2GB of RAM. Here's the relevant portion of the log --

[15:55:29] Finished 'buildPages' after 6.8 s
[15:55:30] Finished 'copyAssets' after 7.19 s
[15:55:34] Finished 'buildStyles' after 12 s
Successfully compiled 131 files with Babel.

<--- Last few GCs --->

[11001:0x47d01c0]   162524 ms: Mark-sweep 934.8 (969.2) -> 934.7 (968.7) MB, 1082.0 / 0.0 ms  (average mu = 0.153, current mu = 0.000) last resort GC                                          in old space requested
[11001:0x47d01c0]   163576 ms: Mark-sweep 934.7 (968.7) -> 934.7 (968.7) MB, 1051.8 / 0.0 ms  (average mu = 0.082, current mu = 0.000) last resort GC                                          in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x13a71b9]
Security context: 0x3d4896b008d1 <JSObject>
    1: _parseMappings(aka SourceMapConsumer_parseMappings) [0x2e8114f3bb11] [/opt/xen-orchestra/node_modules/vinyl-sourcemaps-apply/node_modules/sourc                                         e-map/lib/source-map-consumer.js:~423] [pc=0x2be1bc786448](this=0x2f1c00066241 <BasicSourceMapConsumer map = 0x281cc1fb1089>,0x2d44af900119 <Very long                                          string[4579059]>,0x208e90d801b9 <null>)
    2: get [0x2d06346633...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: 0x9ef190 node::Abort() [gulp build]
 2: 0x9f13b2 node::OnFatalError(char const*, char const*) [gulp build]
 3: 0xb5da9e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [gulp build]
 4: 0xb5de19 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [gulp build]
 5: 0xd0a765  [gulp build]
 6: 0xd1b068 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::Allocatio                                         nAlignment) [gulp build]
 7: 0xce1d2d v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::RootIndex, int, v8::internal::Object, v8::internal::AllocationType) [gulp bu                                         ild]
 8: 0xce1e20 v8::internal::Handle<v8::internal::FixedArray> v8::internal::Factory::NewFixedArrayWithMap<v8::internal::FixedArray>(v8::internal::RootIn                                         dex, int, v8::internal::AllocationType) [gulp build]
 9: 0xf00609 v8::internal::HashTable<v8::internal::NameDictionary, v8::internal::NameDictionaryShape>::New(v8::internal::Isolate*, int, v8::internal::                                         AllocationType, v8::internal::MinimumCapacity) [gulp build]
10: 0xf0ae39 v8::internal::BaseNameDictionary<v8::internal::NameDictionary, v8::internal::NameDictionaryShape>::EnsureCapacity(v8::internal::Isolate*,                                          v8::internal::Handle<v8::internal::NameDictionary>, int) [gulp build]
11: 0xf0af55 v8::internal::Dictionary<v8::internal::NameDictionary, v8::internal::NameDictionaryShape>::Add(v8::internal::Isolate*, v8::internal::Hand                                         le<v8::internal::NameDictionary>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyDetails,                                          int*) [gulp build]
12: 0xf0b089 v8::internal::BaseNameDictionary<v8::internal::NameDictionary, v8::internal::NameDictionaryShape>::AddNoUpdateNextEnumerationIndex(v8::in                                         ternal::Isolate*, v8::internal::Handle<v8::internal::NameDictionary>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::Obj                                         ect>, v8::internal::PropertyDetails, int*) [gulp build]
13: 0xf0b0c5 v8::internal::BaseNameDictionary<v8::internal::NameDictionary, v8::internal::NameDictionaryShape>::Add(v8::internal::Isolate*, v8::intern                                         al::Handle<v8::internal::NameDictionary>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::Object>, v8::internal::Property                                         Details, int*) [gulp build]
14: 0x103b1ec v8::internal::Runtime_AddDictionaryProperty(int, unsigned long*, v8::internal::Isolate*) [gulp build]
15: 0x13a71b9  [gulp build]
Aborted (core dumped)
* xo-web:build − Error: 134
✖ 1
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Builds correctly with 3GB, but would like to stick with 2GB if possible. 😃

[julien-f]

The issue is related to our vastly inefficient build system for xo-web, unfortunately, we don't plan to change it before XO 6 (not for today).

If you see any low-hanging fruits, feel free to submit PRs, otherwise you will need to increase the RAM for building.

Sorry for the inconvenience.

[olivierlambert]

Is this issue still relevant @julien-f ?

[julien-f]

Nope, we can close it 👍