-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: seqvars data-table #1870
feat: seqvars data-table #1870
Conversation
deps-report 🔍Commit scanned: 4d84afa Vulnerable dependencies5 dependencies have vulnerabilities 😱
Outdated dependencies38 outdated dependencies found (including 17 outdated major versions)😢
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
=====================================
Coverage 91% 91%
=====================================
Files 656 656
Lines 37097 37097
=====================================
Hits 33993 33993
Misses 3104 3104 |
I am in the process of adding OpenAPI schema for the results. This includes the types I think the slide-over variant details would add the most value for now. Could you just include this with a placeholder? It's probably most efficient if I integrate this myself after merging. After merging, I will also add some placeholder / stub data until the backend is in place so we can continue here with sensible data. |
@Gregoor I took the liberty of merging |
OK, @Gregoor I will merge this now and integrate with the app. As discussed today in VC, major value points would be:
|
First basic stab at the results data table:
I'm not sure what the highest value thing to add would be right now, until we connect it with real query results. How about the slide-out gene detail view? Afaik we want to reuse the pre-existing view for that.
cc @holtgrewe