Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seqvars data-table #1870

Merged
merged 3 commits into from
Aug 7, 2024
Merged

feat: seqvars data-table #1870

merged 3 commits into from
Aug 7, 2024

Conversation

Gregoor
Copy link
Contributor

@Gregoor Gregoor commented Aug 5, 2024

First basic stab at the results data table:

  • shows fixture data with loading indications when searching/paging
  • customizable column order / visibility

I'm not sure what the highest value thing to add would be right now, until we connect it with real query results. How about the slide-out gene detail view? Afaik we want to reuse the pre-existing view for that.

cc @holtgrewe

Copy link

github-actions bot commented Aug 5, 2024

deps-report 🔍

Commit scanned: 4d84afa
ℹ️ Python version 3.10 is used by your project but the latest version is 3.12.

Vulnerable dependencies

5 dependencies have vulnerabilities 😱
Dependency Advisory Versions impacted
djangorestframework (transitive) Affected versions of the package djangorestframework are vulnerable to Cross-site Scripting (XSS) via the break_long_headers template filter due to improper input sanitization before splitting and joining with
tags.
<3.15.2
jinja2 (transitive) In Jinja2, the from_string function is prone to Server Side Template Injection (SSTI) where it takes the "source" parameter as a template object, renders it, and then returns it. The attacker can exploit it with {{INJECTION COMMANDS}} in a URI. NOTE: The maintainer and multiple third parties believe that this vulnerability isn't valid because users shouldn't use untrusted templates without sandboxing. >=0
pyopenssl (transitive) CVE-2023-6129 affects PyOpenSSL versions starting from 22.0.0 due to a vulnerability in the POLY1305 MAC algorithm on PowerPC CPUs. This issue could lead to state corruption in applications, causing inaccurate outcomes or service disruptions. Attackers need specific conditions to exploit this flaw, including the ability to manipulate the algorithm's use and reliance on certain system registers by the application. >=22.0.0
setuptools (transitive) Affected versions of Setuptools allow for remote code execution via its download functions. These functions, which are used to download packages from URLs provided by users or retrieved from package index servers, are susceptible to code injection. If these functions are exposed to user-controlled inputs, such as package URLs, they can execute arbitrary commands on the system. <70.0.0
sqlalchemy Sqlalchemy 2.0.0b1 avoids leaking cleartext passwords to the open for careless uses of str(engine.URL()) in logs and prints. sqlalchemy/sqlalchemy#8563 <2.0.0b1

Outdated dependencies

38 outdated dependencies found (including 17 outdated major versions)😢
Dependency Installed version Latest version
alabaster (transitive) 0.7.16 1.0.0
argon2-cffi (transitive) 21.3.0 23.1.0
attrs 23.2.0 24.2.0
billiard (transitive) 3.6.4.0 4.2.0
crispy-bootstrap4 (transitive) 2022.1 2024.1
django 3.2.25 5.0.8
django-rest-knox (transitive) 4.2.0 5.0.1
django-sodar-core 0.13.4 1.0.0
mistune (transitive) 2.0.5 3.0.2
packaging (transitive) 23.2 24.1
protobuf 3.20.3 5.27.3
setuptools (transitive) 67.6.1 72.1.0
sphinx (transitive) 6.2.1 8.0.2
sphinx-rtd-theme (transitive) 1.2.2 2.0.0
sqlalchemy 1.4.53 2.0.32
unidecode (transitive) 0.4.21 1.3.8
xmlschema (transitive) 2.5.1 3.3.2
Dependency Installed version Latest version
botocore (transitive) 1.34.131 1.34.155
celery (transitive) 5.2.7 5.4.0
django-autocomplete-light (transitive) 3.9.4 3.11.0
django-crispy-forms (transitive) 2.0 2.3
django-db-file-storage (transitive) 0.5.5 0.5.6.1
django-debug-toolbar 4.3.0 4.4.6
django-environ (transitive) 0.10.0 0.11.2
django-iconify (transitive) 0.1.1 0.4
django-model-utils (transitive) 4.3.1 4.5.1
django-plugins-bihealth 0.4.0 0.5.2
django-postgres-copy 2.3.7 2.7.4
djangorestframework (transitive) 3.14.0 3.15.2
docutils (transitive) 0.18.1 0.21.2
drf-keyed-list-bihealth 0.1.1 0.2.1
markdown (transitive) 3.4.1 3.6
mypy-protobuf (dev) 3.3.0 3.6.0
pydantic-core (transitive) 2.20.1 2.21.0
requests-http-signature 0.2.0 0.7.1
rules (transitive) 3.3 3.4
versioneer (transitive) 0.28 0.29
wheel (transitive) 0.40.0 0.44.0

Logs

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91%. Comparing base (3215233) to head (4d84afa).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1870   +/-   ##
=====================================
  Coverage     91%     91%           
=====================================
  Files        656     656           
  Lines      37097   37097           
=====================================
  Hits       33993   33993           
  Misses      3104    3104           

@holtgrewe
Copy link
Collaborator

I am in the process of adding OpenAPI schema for the results. This includes the types SeqvarsResultSet and SeqvarsResultRow with meta information on results and the row(s) themselves. I will CC you there.

I think the slide-over variant details would add the most value for now. Could you just include this with a placeholder? It's probably most efficient if I integrate this myself after merging. After merging, I will also add some placeholder / stub data until the backend is in place so we can continue here with sensible data.

@holtgrewe
Copy link
Collaborator

@Gregoor I took the liberty of merging main into the branch and fixing issues with API type name changes

@holtgrewe
Copy link
Collaborator

OK, @Gregoor I will merge this now and integrate with the app. As discussed today in VC, major value points would be:

  • slide-over variant details with placeholder
  • demonstration of more unit and playwright tests

@holtgrewe holtgrewe marked this pull request as ready for review August 7, 2024 13:44
@holtgrewe holtgrewe merged commit d5cb17b into main Aug 7, 2024
17 checks passed
@holtgrewe holtgrewe deleted the seqvars-data-table branch August 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants