-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: splitting recessive_parent into recessive_{father,mother} (#1867) #1868
feat: splitting recessive_parent into recessive_{father,mother} (#1867) #1868
Conversation
@Gregoor afterwards we should merge |
deps-report 🔍Commit scanned: 5de7f07 Vulnerable dependencies5 dependencies have vulnerabilities 😱
Outdated dependencies48 outdated dependencies found (including 17 outdated major versions)😢
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
=====================================
Coverage 91% 91%
=====================================
Files 653 653
Lines 36856 36880 +24
=====================================
+ Hits 33741 33765 +24
Misses 3115 3115
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I am a bit domain-confused that it is possible to select e.g. two biological fathers, but I suppose that works as intended?
On a UI level I'm now leaning towards replacing the radio group with a dropdown to retain the same filter sidebar width. Wdyt?
Actually, the backend will throw an error for more than one father or mother. |
@Gregoor could you review the frontend part that you wrote?