Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves error messages when getaddrinfo() fails #161

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Feb 14, 2018

No description provided.

…etaddrinfo() when throwing error messages, including printing the hostname and port on which binding was attempted.
Copy link
Contributor

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big annoyance out of the way, yet again!

@tanner0101 tanner0101 added this to the 3.0.0-beta.3 milestone Feb 14, 2018
@tanner0101 tanner0101 self-assigned this Feb 14, 2018
@tanner0101
Copy link
Collaborator

Awesome, thank you!

@tanner0101 tanner0101 merged commit f93514d into beta Feb 14, 2018
@tanner0101 tanner0101 deleted the feature/better-getaddrinfo-errors branch February 14, 2018 18:58
@tanner0101 tanner0101 modified the milestones: 3.0.0-beta.3, 3.0.0-beta.2 Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants