Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PyTorch requirements from ">=1.10.0,<2.0" to "2.0.1" #234

Closed
kacpersh opened this issue Sep 12, 2023 · 3 comments
Closed

Upgrade PyTorch requirements from ">=1.10.0,<2.0" to "2.0.1" #234

kacpersh opened this issue Sep 12, 2023 · 3 comments

Comments

@kacpersh
Copy link

kacpersh commented Sep 12, 2023

torch>=1.10.0,<2.0

Hello synthcity Team,

Are there any plans to update the library file from ">=1.10.0,<2.0" to "2.0.1"?

At the moment pip install synthcity installs the package successfully, but raises the following error:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. torchaudio 2.0.2+cu118 requires torch==2.0.1, but you have torch 1.13.1 which is incompatible. torchdata 0.6.1 requires torch==2.0.1, but you have torch 1.13.1 which is incompatible.

I need to reinstall torch with the newest version afterwards to avoid import issues from the synthcity package. It also prevents from using tools like pipenv due to conflicts in sub-dependencies.

Also, pip installation of the synthcity package requires PyTorch to be installed beforehand. Is it intended?

Best,
Kacper

@robsdavis
Copy link
Contributor

Hi Kacper,

Yes, this work is planned for development soon and an issue already exists for this work, #171. Unfortunately, because of various dependencies it is quite a big job, requiring careful consideration. Nevertheless, I hope to get back to you with this improvement soon.

Until then there is a solution to your issue that doesn't involve breaking Synthcity's requirements. torchaudio comes pre-installed on some environments, for example the most recent google Colab environment, however Synthcity does not require torchaudio at all. So, you can simply pip uninstall torchaudio and the conflict should disappear. If you do in fact need torchaudio for your work, you will need to install an earlier version that is compatible with torch 1.13.1.

And on the issue of the PyTorch installation prior to installing synthcity, yes that is necessary in order for everything to resolve correctly. If you have cloned the repo, you can do it simply with pip install -r prereq.txt.

@HLasse
Copy link
Contributor

HLasse commented Dec 29, 2023

Any updates on this,@robsdavis? Is is being worked on or is it off the table for now? Upgrading the supported pytorch versions would be of immense help for us! :)

@paulduf
Copy link

paulduf commented Feb 21, 2024

I'm also asking for this upgrade, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants