Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pip 23.1 in workflows #183

Closed
robsdavis opened this issue Apr 20, 2023 · 3 comments
Closed

Add support for pip 23.1 in workflows #183

robsdavis opened this issue Apr 20, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@robsdavis
Copy link
Contributor

Description

Currently, upgrading pip to 23.1 causes a fail in the .github/workflows, so the version of pip is pinned to 23.0.1. This constraint should be removed.

@tztsai
Copy link

tztsai commented Apr 20, 2023

It seems that the failure of importing torch in building the wheel of geomloss may be related to the version of "wheel" or "setuptool". After it runs the following commands, there is no longer this error. I'm not sure what is the real cause of this problem, because yesterday the workflow was free of this error without upgrading "wheel" or "setuptool" as well.

图片

@tztsai
Copy link

tztsai commented Apr 21, 2023

So by upgrading "setuptools" and "wheel" the dependencies can be successfully installed with pip 23.1; otherwise there will be an ImportError of torch when building geomloss. Keeping pip version to 23.0.1 also worked, so I think a possible explanation is that the newest versions of "setuptools" or "wheel" must be installed to match the new release of pip 23.1. But it is just hypothetical.

@robsdavis robsdavis added the bug Something isn't working label Apr 25, 2023
@robsdavis
Copy link
Contributor Author

This is fixed by #178. Thanks @tztsai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants