Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing p12 password doesn't cause the p12 cert to be regenerated. #36

Closed
JimPaine opened this issue Mar 11, 2019 · 0 comments · Fixed by #37
Closed

Changing p12 password doesn't cause the p12 cert to be regenerated. #36

JimPaine opened this issue Mar 11, 2019 · 0 comments · Fixed by #37

Comments

@JimPaine
Copy link
Contributor

Hi All,

Sorry of the back of the #32 I believe an additional change is required.

When changing the p12 password the p12 (pfx) isn't regenerated due to a check in the update method that looks to see if the certificate_pem has changed. If it hasn't it ignores all other changes. See here

Expected Outcome

Changing the attribute certificate_p12_password should update the certificate_p12 to be a new base64 encoded certificate using the existing pem

Actual Outcome

The password is updated in the state but the base64 encoded certificated is the same as the existing one using the previous password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant