Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication between common name and SANs incorrectly disallowed #90

Closed
jekor opened this issue Sep 10, 2019 · 1 comment
Closed

Duplication between common name and SANs incorrectly disallowed #90

jekor opened this issue Sep 10, 2019 · 1 comment

Comments

@jekor
Copy link

jekor commented Sep 10, 2019

Error: common name X should not appear in SAN list

This prevents creating compatible certificates that contain all names in the SAN list and one of those names (arbitrarily) in the Common Name.

See https://stackoverflow.com/questions/5935369/ssl-how-do-common-names-cn-and-subject-alternative-names-san-work-together

@vancluever
Copy link
Owner

@jekor this will be allowed in v2.0.0.

Note that this is a semantic change - this is already de-duplicated on the lego side and issued certificates do contain both the CN in the SAN list in addition to the subject_alternative_names specified. But hopefully it should eliminate confusion on whether or not this is actually the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants