Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question regarding TCPDialer and KeepAlive #1667

Open
qpbd86 opened this issue Nov 23, 2023 · 1 comment
Open

Question regarding TCPDialer and KeepAlive #1667

qpbd86 opened this issue Nov 23, 2023 · 1 comment

Comments

@qpbd86
Copy link

qpbd86 commented Nov 23, 2023

Is doesn't look there is a way to pass KeepAlive configuration (ref) to the underlying net.Dialer used by TCPDialer here. A simple approach might be to add another public field to the TCPDialer struct here, is that something that could be supported? I have a use-case that requires a shorter interval than the default, and it would be great to use the TCPDialer for it. Happy to contribute an implementation if it's welcome!
@erikdubbelboer
Copy link
Collaborator

I'm open to a pull request that adds an extra field for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikdubbelboer @qpbd86