Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): use prev safari version while latest doesnt work on sauce #5011

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

ludmilanesvitiy
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned ludmilanesvitiy Jan 16, 2019
@ghost ghost added the needs review label Jan 16, 2019
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #5011 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5011      +/-   ##
===============================================
+ Coverage        74.81%   74.83%   +0.02%     
===============================================
  Files              277      277              
  Lines             8436     8436              
  Branches          1603     1603              
===============================================
+ Hits              6311     6313       +2     
- Misses            1677     1680       +3     
+ Partials           448      443       -5
Impacted Files Coverage Δ
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 72.47% <0%> (-1.84%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/chronos/i18n/pl.ts 74.35% <0%> (ø) ⬆️
src/chronos/utils/date-getters.ts 81.81% <0%> (+2.27%) ⬆️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️
src/datepicker/engine/flag-days-calendar.ts 81.25% <0%> (+6.25%) ⬆️
src/chronos/i18n/it.ts 100% <0%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d338dbf...7be3cb5. Read the comment docs.

@valorkin valorkin added this to the 3.1.5 milestone Jan 18, 2019
@valorkin valorkin merged commit 89f7265 into development Jan 18, 2019
@ghost ghost removed the ready for merge label Jan 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-saucelab-browser branch January 18, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants