Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): fix responsive on Date Range Picker (#4127) #4891

Conversation

llysenko
Copy link
Contributor

@llysenko llysenko commented Dec 5, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Issue: #4127

@ghost ghost added the needs review label Dec 5, 2018
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #4891 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4891   +/-   ##
============================================
  Coverage        75.66%   75.66%           
============================================
  Files              237      237           
  Lines             7336     7336           
  Branches          1464     1464           
============================================
  Hits              5551     5551           
+ Misses            1379     1377    -2     
- Partials           406      408    +2
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 72.22% <0%> (-2.78%) ⬇️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/typeahead/typeahead.directive.ts 74.86% <0%> (+1.04%) ⬆️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bd459...aa98d63. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #4891 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4891   +/-   ##
============================================
  Coverage        75.66%   75.66%           
============================================
  Files              237      237           
  Lines             7336     7336           
  Branches          1464     1464           
============================================
  Hits              5551     5551           
+ Misses            1379     1377    -2     
- Partials           406      408    +2
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 72.22% <0%> (-2.78%) ⬇️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/typeahead/typeahead.directive.ts 74.86% <0%> (+1.04%) ⬆️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bd459...aa98d63. Read the comment docs.

@valorkin valorkin added this to the 3.1.3 milestone Dec 6, 2018
@ludmilanesvitiy
Copy link
Contributor

Datepicker Tested in Chrome, FF - latest, with bs3,4, diff zoom and diff screen resolutions. Now it looks much better than previously) Thanks!

@valorkin valorkin merged commit 53b88c0 into valor-software:development Dec 6, 2018
@ghost ghost removed the ready for merge label Dec 6, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants