Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(demo): opportunity to change bs theme by url query #4870

Merged
merged 2 commits into from
Dec 5, 2018
Merged

feat(demo): opportunity to change bs theme by url query #4870

merged 2 commits into from
Dec 5, 2018

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Dec 3, 2018 •
edited
Loading

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Dec 3, 2018
@ghost ghost added the needs review label Dec 3, 2018
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #4870 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4870   +/-   ##
============================================
  Coverage        75.65%   75.65%           
============================================
  Files              237      237           
  Lines             7336     7336           
  Branches          1464     1464           
============================================
  Hits              5550     5550           
  Misses            1376     1376           
  Partials           410      410

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb65d16...a87121f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 3, 2018 •
edited
Loading

Codecov Report

Merging #4870 into development will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4870      +/-   ##
===============================================
+ Coverage        75.65%   75.69%   +0.04%     
===============================================
  Files              237      237              
  Lines             7336     7336              
  Branches          1464     1464              
===============================================
+ Hits              5550     5553       +3     
+ Misses            1376     1375       -1     
+ Partials           410      408       -2
Impacted Files Coverage Δ
src/chronos/i18n/cs.ts 86.44% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 82.97% <0%> (ø) ⬆️
src/chronos/i18n/pl.ts 75% <0%> (+2.77%) ⬆️
src/chronos/i18n/it.ts 100% <0%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de72f9...bc27db6. Read the comment docs.

@valorkin valorkin added this to the 3.1.3 milestone Dec 3, 2018
valorkin
valorkin requested changes Dec 3, 2018
View reviewed changes
demo/src/app/common/sidebar/sidebar.component.ts Outdated
pluck('_bsVersion')
)
.subscribe((bsVersion: 'bs3' | 'bs4') => {
this.installTheme(bsVersion);

This comment was marked as off-topic.

Sign in to view

demo/src/app/common/sidebar/sidebar.component.ts Outdated
@@ -47,6 +51,14 @@ export class SidebarComponent implements OnDestroy {
this.toggle(false);
}
});

this.activatedRoute.queryParams

This comment was marked as off-topic.

Sign in to view

@Domainv Domainv force-pushed the feat-demo-change-theme-by-url branch from 1537ec9 to fa57a1b Compare December 3, 2018 17:17
@ghost ghost assigned ludmilanesvitiy Dec 4, 2018
@ghost ghost added the needs review label Dec 4, 2018
@ludmilanesvitiy
Copy link
Contributor

Smoke tested, looks good.

@valorkin valorkin merged commit 0e806e1 into development Dec 5, 2018
@ghost ghost removed the ready for merge label Dec 5, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-demo-change-theme-by-url branch December 5, 2018 18:33
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@Domainv @leo6104
feat(demo): opportunity to change bs theme by url query (valor-softwa…
bbd06c2 
…re#4870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

Assignees

@valorkin valorkin

@Domainv Domainv

@ludmilanesvitiy ludmilanesvitiy

Labels
needs review
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Domainv @ludmilanesvitiy @valorkin