Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add full coverage for Pagination component demo #4867

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

ludmilanesvitiy
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #4867 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4867   +/-   ##
============================================
  Coverage        75.65%   75.65%           
============================================
  Files              237      237           
  Lines             7336     7336           
  Branches          1464     1464           
============================================
  Hits              5550     5550           
  Misses            1376     1376           
  Partials           410      410

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb65d16...5ecc5d2. Read the comment docs.

@ludmilanesvitiy ludmilanesvitiy force-pushed the feat-e2e-pagination-full branch from 5b58592 to 8c15a67 Compare December 3, 2018 11:49
@ludmilanesvitiy ludmilanesvitiy changed the title WIP: feat(tests): add full coverage for Pagination component demo feat(tests): add full coverage for Pagination component demo Dec 3, 2018
pagination.clickOnPager(pageChangedEvent, 'Previous');
pagination.isPagerDisabled(pageChangedEvent, 'Previous', true);
pagination.isPagerDisabled(pageChangedEvent, 'Next', false);
pagination.isPreviewExist(pageChangedEvent, ' Page changed to: 1\n');

This comment was marked as off-topic.

@ludmilanesvitiy ludmilanesvitiy force-pushed the feat-e2e-pagination-full branch from 8c15a67 to 7361b55 Compare December 3, 2018 13:23
valorkin
valorkin previously approved these changes Dec 3, 2018
@ludmilanesvitiy ludmilanesvitiy force-pushed the feat-e2e-pagination-full branch from 7361b55 to 5ecc5d2 Compare December 3, 2018 14:25
@valorkin valorkin merged commit 30d2734 into development Dec 3, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-e2e-pagination-full branch December 3, 2018 14:26
@ghost ghost removed the needs review label Dec 3, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants