Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add full coverage for Collapse component demo #4847

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

ludmilanesvitiy
Copy link
Contributor

#INFO - IMPORTANT
This PR based on #4838 and should be merged only after 4838.

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #4847 into development will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4847      +/-   ##
===============================================
- Coverage        75.85%   75.65%   -0.21%     
===============================================
  Files              237      237              
  Lines             7336     7336              
  Branches          1464     1464              
===============================================
- Hits              5565     5550      -15     
- Misses            1369     1376       +7     
- Partials           402      410       +8
Impacted Files Coverage Δ
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/pl.ts 72.22% <0%> (-11.12%) ⬇️
src/chronos/i18n/sk.ts 82.97% <0%> (-8.52%) ⬇️
src/chronos/i18n/cs.ts 86.44% <0%> (-6.78%) ⬇️
src/chronos/i18n/uk.ts 78.04% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1662554...3f89804. Read the comment docs.

@ghost ghost added the needs review label Dec 3, 2018
@valorkin valorkin merged commit bb65d16 into development Dec 3, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-e2e-collapse-full branch December 3, 2018 14:20
@ghost ghost removed the needs review label Dec 3, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants