Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datepicker): allow to select dates from other months #4828

Merged
merged 7 commits into from
Dec 6, 2018
Merged

feat(datepicker): allow to select dates from other months #4828

merged 7 commits into from
Dec 6, 2018

Conversation

daniloff200
Copy link
Contributor

@daniloff200 daniloff200 commented Nov 21, 2018 •
edited
Loading

closes #4485
closes #3746

A new property for BsConfig was added : selectFromOtherMonth

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost added the needs review label Nov 21, 2018
@codecov
Copy link

codecov bot commented Nov 21, 2018 •
edited
Loading

Codecov Report

Merging #4828 into development will decrease coverage by 0.06%.
The diff coverage is 30.76%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4828      +/-   ##
===============================================
- Coverage        74.72%   74.66%   -0.07%     
===============================================
  Files              273      273              
  Lines             8336     8347      +11     
  Branches          1588     1591       +3     
===============================================
+ Hits              6229     6232       +3     
- Misses            1672     1677       +5     
- Partials           435      438       +3
Impacted Files Coverage Δ
...themes/bs/bs-datepicker-day-decorator.directive.ts 100% <ø> (ø) ⬆️
src/datepicker/base/bs-datepicker-container.ts 78.94% <ø> (ø) ⬆️
src/datepicker/models/index.ts 100% <ø> (ø) ⬆️
src/datepicker/reducer/bs-datepicker.state.ts 100% <ø> (ø) ⬆️
src/datepicker/bs-datepicker.config.ts 100% <ø> (ø) ⬆️
...hemes/bs/bs-daterangepicker-container.component.ts 29.26% <0%> (-1.51%) ⬇️
src/chronos/i18n/pl.ts 71.79% <33.33%> (-5.99%) ⬇️
...ker/themes/bs/bs-datepicker-container.component.ts 84.84% <33.33%> (-2.25%) ⬇️
...icker/themes/bs/bs-days-calendar-view.component.ts 69.56% <50%> (-4.12%) ⬇️
src/datepicker/engine/flag-days-calendar.ts 73.33% <0%> (-6.67%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a551277...e3eaa27. Read the comment docs.

Domainv
Domainv suggested changes Nov 26, 2018
View reviewed changes
src/datepicker/bs-datepicker.config.ts Outdated Show resolved Hide resolved
@ghost ghost added the needs review label Dec 2, 2018
@valorkin valorkin added this to the 3.1.3 milestone Dec 3, 2018
@ghost ghost assigned ludmilanesvitiy Dec 6, 2018
@ludmilanesvitiy
Copy link
Contributor

New Demo for Datepicker Tested in CHrome, FF - latest, looks good.

@ghost ghost assigned Domainv Dec 6, 2018
valorkin
valorkin approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valorkin valorkin merged commit b17926b into valor-software:development Dec 6, 2018
@ghost ghost removed the ready for merge label Dec 6, 2018
@daniloff200 daniloff200 deleted the fix-dates-from-other-months branch December 6, 2018 11:10
@daniloff200 daniloff200 mentioned this pull request Dec 16, 2018
Closed
5 tasks
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@daniloff200 @leo6104
feat(datepicker): allow to select dates from other months (valor-soft…
497aa18 
…ware#4828)

closes valor-software#4485
closes valor-software#3746
@daniloff200 daniloff200 mentioned this pull request Jan 20, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Domainv Domainv Domainv approved these changes

@valorkin valorkin valorkin approved these changes

Assignees

@valorkin valorkin

@Domainv Domainv

@ludmilanesvitiy ludmilanesvitiy

Labels
comp(datepicker)
Projects
None yet
Milestone
3.1.3
4 participants
@daniloff200 @ludmilanesvitiy @valorkin @Domainv