Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(doc): added docs for modals component #4679

Merged
merged 1 commit into from
Oct 12, 2018
Merged

feat(doc): added docs for modals component #4679

merged 1 commit into from
Oct 12, 2018

Conversation

OlegDubrovskyi
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned OlegDubrovskyi Oct 10, 2018
@OlegDubrovskyi OlegDubrovskyi force-pushed the feat-docs-case-modals branch 2 times, most recently from bfc525d to d1a3f62 Compare October 10, 2018 14:24
@codecov
Copy link

codecov bot commented Oct 10, 2018 •
edited
Loading

Codecov Report

Merging #4679 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4679   +/-   ##
============================================
  Coverage        71.44%   71.44%           
============================================
  Files              259      259           
  Lines             8378     8378           
  Branches          1562     1562           
============================================
  Hits              5986     5986           
  Misses            1985     1985           
  Partials           407      407

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9980218...ba84aef. Read the comment docs.

ludmilanesvitiy
ludmilanesvitiy reviewed Oct 11, 2018
View reviewed changes
docs/spec/index.md Outdated

[Service examples. Backdrop options](modals/modals.service-examples.backdrop-options.use-case.md)

[Service examples. Static modal](modals/modals.directive-examples.static-modal.use-cases.md)

This comment was marked as off-topic.

Sign in to view

docs/spec/index.md Outdated

[Service examples. Static modal](modals/modals.directive-examples.static-modal.use-cases.md)

[Service examples. Optional sizes](modals/modals.directive-examples.optional-sizes.md)

This comment was marked as off-topic.

Sign in to view

docs/spec/index.md Outdated

[Service examples. Optional sizes](modals/modals.directive-examples.optional-sizes.md)

[Service examples. Child modal](modals/modals.directive-examples.child-modal.use-case.md)

This comment was marked as off-topic.

Sign in to view

docs/spec/index.md Outdated

[Service examples. Child modal](modals/modals.directive-examples.child-modal.use-case.md)

[Service examples. Nested modals](modals/modals.directive-examples.nested-modals.use-cases.md)

This comment was marked as off-topic.

Sign in to view

docs/spec/index.md Outdated

[Service examples. Nested modals](modals/modals.directive-examples.nested-modals.use-cases.md)

[Service examples. Modal events](modals/modals.directive-examples.modal-events.use-cases.md)

This comment was marked as off-topic.

Sign in to view

docs/spec/index.md Outdated

[Service examples. Modal events](modals/modals.directive-examples.modal-events.use-cases.md)

[Service examples. Auto shown modal](modals/modals.directive-examples.auto-shown-modal.md)

This comment was marked as off-topic.

Sign in to view

docs/spec/modals/modals.directive-examples.nested-modals.use-cases.md Outdated

1. User opens 'Modals' demo page
2. User clicks on 'Nested modals' sub-menu
3. After click on "Open parent modal" button, modal popup is opened and user sees 'Open second modal' button

This comment was marked as off-topic.

Sign in to view

docs/spec/modals/modals.service-examples.nested.use-case.md Outdated
Variations:
----------

2.a User scrolls to Nested

This comment was marked as off-topic.

Sign in to view

@ghost ghost added needs review and removed needs fix labels Oct 11, 2018
@valorkin valorkin merged commit 6e32261 into valor-software:development Oct 12, 2018
@ghost ghost removed the ready for merge label Oct 12, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@OlegDubrovskyi @leo6104
feat(doc): added docs for modals component (valor-software#4679)
4d32a3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludmilanesvitiy ludmilanesvitiy ludmilanesvitiy approved these changes

Assignees

@OlegDubrovskyi OlegDubrovskyi

Labels
comp(modal) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegDubrovskyi @ludmilanesvitiy @valorkin