Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(timepicker): changed description for arrow keys #4672

Merged
merged 4 commits into from
Oct 12, 2018
Merged

doc(timepicker): changed description for arrow keys #4672

merged 4 commits into from
Oct 12, 2018

Conversation

tarusin
Copy link
Contributor

@tarusin tarusin commented Oct 5, 2018

PR Checklist

Before creating new PR, please take a look at the checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Issue: #4307

@ghost ghost added the needs review label Oct 5, 2018
@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #4672 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4672   +/-   ##
============================================
  Coverage        71.44%   71.44%           
============================================
  Files              259      259           
  Lines             8378     8378           
  Branches          1562     1562           
============================================
  Hits              5986     5986           
  Misses            1985     1985           
  Partials           407      407
Impacted Files Coverage Δ
src/timepicker/timepicker.component.ts 94.52% <ø> (ø) ⬆️
src/timepicker/timepicker.config.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e32261...810e096. Read the comment docs.

@ghost ghost assigned Domainv Oct 5, 2018
@Domainv Domainv changed the title fix(timepicker): changed description for arrow keys doc(timepicker): changed description for arrow keys Oct 12, 2018
@valorkin valorkin merged commit 4a58fe3 into valor-software:development Oct 12, 2018
@ghost ghost removed the ready for merge label Oct 12, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants