Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): fix right sidebar on IE and Edge #4658

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

YuriiKrvc
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost added the needs review label Oct 1, 2018
@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #4658 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4658   +/-   ##
============================================
  Coverage        71.44%   71.44%           
============================================
  Files              259      259           
  Lines             8378     8378           
  Branches          1562     1562           
============================================
  Hits              5986     5986           
  Misses            1985     1985           
  Partials           407      407

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e32261...c8e1c3d. Read the comment docs.

Domainv
Domainv previously approved these changes Oct 2, 2018
@OlegDubrovskyi
Copy link
Contributor

IE11, Edge, Chrome, Firefox - right sidebar looks good. But behavior left sidebar is incorrectly after click by links in right sidebar.

Steps to reproduce:

  1. Use IE11 browser
  2. Open ngx-bootstrap demo
  3. Go to any component
  4. In right sidebar click by any links

Actual result: I don't see left sidebar
Expected result: I should see left sidebar

left_sidebar

@OlegDubrovskyi
Copy link
Contributor

@Yuriy777 After fix needs to fix the same for other browsers besides IE

@OlegDubrovskyi
Copy link
Contributor

Looks good.
Checked on IE11, Edge, Chrome, Firefox, Safari

@ghost ghost assigned Domainv Oct 11, 2018
@valorkin valorkin merged commit 63af3e1 into valor-software:development Oct 12, 2018
@ghost ghost removed the ready for merge label Oct 12, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants