fix(build): build with ng-packagr #4617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Domainv
force-pushed
the
feat-build-with-packagr
branch
8 times, most recently
from
a075d5d to
a544620
Compare
Domainv
force-pushed
the
feat-build-with-packagr
branch
from
a544620 to
e767b64
Compare
Codecov Report
@@ Coverage Diff @@
## development #4617 +/- ##
===============================================
+ Coverage 71.48% 74.35% +2.87%
===============================================
Files 259 202 -57
Lines 8384 7101 -1283
Branches 1562 1446 -116
===============================================
- Hits 5993 5280 -713
+ Misses 1985 1426 -559
+ Partials 406 395 -11
Continue to review full report at Codecov.
|
Domainv
force-pushed
the
feat-build-with-packagr
branch
2 times, most recently
from
4904da6 to
751aa49
Compare
Domainv
changed the title
Domainv
force-pushed
the
feat-build-with-packagr
branch
3 times, most recently
from
6ce20eb to
e5ab73d
Compare
|
Looks good. |
Domainv
force-pushed
the
feat-build-with-packagr
branch
3 times, most recently
from
a49808a to
1b59ca0
Compare
Domainv
force-pushed
the
feat-build-with-packagr
branch
from
2cf5ebd to
fa2817f
Compare
Domainv
force-pushed
the
feat-build-with-packagr
branch
from
8ebab9d to
b82b31a
Compare
|
Looks good. |
valorkin
approved these changes
Oct 15, 2018
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
* fix(build): build with ng-packagr * chore(changelog): update [skip ci] * fix(changelog): changelog revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4535 #4495 #4494 #4413 #4380 #4552
After adding new ngx-bootstrap version (build with ng-packagr)
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.