-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): fix dropdown inside click #4609
Conversation
Looks good. |
Codecov Report
@@ Coverage Diff @@
## development #4609 +/- ##
===============================================
+ Coverage 75.66% 75.96% +0.29%
===============================================
Files 237 237
Lines 7336 7344 +8
Branches 1464 1466 +2
===============================================
+ Hits 5551 5579 +28
+ Misses 1379 1355 -24
- Partials 406 410 +4
Continue to review full report at Codecov.
|
Tested, in FF 63.0 dropdown didn't close by outside click, in IE and Chrome works well. And looks like this PR need additional unit-tests. |
@ludmilanesvitiy issue in Firefox was fixed, tests was added |
|
||
it('should set isOpen property', () => { | ||
component.isOpen = true; | ||
expect(component.isOpen).toBeTruthy(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Related to: #1933
PR Checklist