Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): fix dropdown inside click #4609

Merged
merged 5 commits into from Dec 5, 2018
Merged

fix(dropdown): fix dropdown inside click #4609

merged 5 commits into from Dec 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2018

  • fix dropdown inside click
  • fixed dropdown's and accordion's tests

Related to: #1933

PR Checklist

@ghost ghost added the needs review label Sep 13, 2018
@ghost ghost changed the title fix(dropdown): fix dropdown tests fix(dropdown): fix dropdown inside click Sep 13, 2018
Domainv
Domainv previously approved these changes Sep 20, 2018
@OlegDubrovskyi
Copy link
Contributor

Looks good.
Checked on Firefox, Chrome, IE11, Edge

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #4609 into development will increase coverage by 0.29%.
The diff coverage is 81.81%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4609      +/-   ##
===============================================
+ Coverage        75.66%   75.96%   +0.29%     
===============================================
  Files              237      237              
  Lines             7336     7344       +8     
  Branches          1464     1466       +2     
===============================================
+ Hits              5551     5579      +28     
+ Misses            1379     1355      -24     
- Partials           406      410       +4
Impacted Files Coverage Δ
src/dropdown/bs-dropdown-toggle.directive.ts 85.71% <100%> (+1.09%) ⬆️
src/dropdown/bs-dropdown.directive.ts 78.46% <75%> (+4.44%) ⬆️
src/dropdown/bs-dropdown-container.component.ts 70% <75%> (+44.07%) ⬆️
src/typeahead/typeahead.directive.ts 74.86% <0%> (+1.04%) ⬆️
src/utils/theme-provider.ts 65.21% <0%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bd459...cd6226b. Read the comment docs.

valorkin
valorkin previously approved these changes Oct 12, 2018
@ghost ghost assigned valorkin Oct 12, 2018
@ghost ghost dismissed stale reviews from valorkin and Domainv via 8a5ef6a November 13, 2018 14:33
@ludmilanesvitiy
Copy link
Contributor

Tested, in FF 63.0 dropdown didn't close by outside click, in IE and Chrome works well. And looks like this PR need additional unit-tests.

@ghost
Copy link
Author

ghost commented Nov 15, 2018

@ludmilanesvitiy issue in Firefox was fixed, tests was added

@valorkin valorkin added this to the 3.1.3 milestone Dec 3, 2018

it('should set isOpen property', () => {
component.isOpen = true;
expect(component.isOpen).toBeTruthy();

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@valorkin valorkin merged commit 75f7105 into valor-software:development Dec 5, 2018
@ghost ghost removed the needs review label Dec 5, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants