fix(datepicker): select correct month and year from month picker view… #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when displayMonths > 1
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## development #4501 +/- ##
===============================================
- Coverage 75.66% 74.43% -1.23%
===============================================
Files 237 273 +36
Lines 7336 8321 +985
Branches 1464 1582 +118
===============================================
+ Hits 5551 6194 +643
- Misses 1379 1694 +315
- Partials 406 433 +27
Continue to review full report at Codecov.
|
|
@johnsmathew hey, thans for PR! Could you please add a test case for this issue? |
|
@valorkin Added test case for this scenario. I couldn't find any spec files for datepicker. So created a new spec file. |
|
@valorkin Can this be reviewed and merged please. |
|
Tested in Chrome, FF - latest, looks good. Need to update test for not disabling ts-lint rules and ready for merge. |
Domainv
approved these changes
Dec 5, 2018
valorkin
approved these changes
Dec 5, 2018
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
valor-software#4501) * fix(datepicker): select correct month and year from month picker view when displayMonths > 1 * test(datepicker): select correct year on month selection * test(datepicker): add test for show and hide * fix(tslint): fix tslint errors * feat(common): clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when displayMonths > 1
Fixes #4500
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.